Closed Bug 1388211 Opened 5 years ago Closed 5 years ago

Fold ExtensionAPI.jsm into ExtensionCommon.jsm

Categories

(WebExtensions :: General, enhancement)

Product:
WebExtensions
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm.
59 bytes, text/x-review-board-request
mixedpuppy
: review+
Details 
We always load one when we load the other, so there's no need for the overhead of a separate JSM.
Comment on attachment 8894700 [details]
Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm.

https://reviewboard.mozilla.org/r/165866/#review171270

::: toolkit/components/extensions/ExtensionCommon.jsm:91
(Diff revision 1)
>    [Symbol.iterator]() {
>      return this.unwrappedValues[Symbol.iterator]();
>    }
>  }
>  
> +class ExtensionAPI extends ExtensionUtils.EventEmitter {

Why is this extending the EventEmitter now, nothing else seems to have changed about the code?
Comment on attachment 8894700 [details]
Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm.

https://reviewboard.mozilla.org/r/165866/#review171270

> Why is this extending the EventEmitter now, nothing else seems to have changed about the code?

This is on top of bug 1387898. Reviewboard just sucks.
Comment on attachment 8894700 [details]
Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm.

https://reviewboard.mozilla.org/r/165866/#review171280
Attachment #8894700 - Flags: review?(mixedpuppy) → review+
https://hg.mozilla.org/mozilla-central/rev/6f7aa77d3ac9
https://hg.mozilla.org/mozilla-central/rev/eefbc4d0360e
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: 1373418
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.