Fold ExtensionAPI.jsm into ExtensionCommon.jsm

RESOLVED FIXED in Firefox 57

Status

Product:
WebExtensions
Component:
General
Status:
RESOLVED FIXED
Reported:
2 years ago
Modified:
8 months ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

(Blocks: 2 bugs)

Version:
unspecified
Target:
mozilla57
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm.
59 bytes, text/x-review-board-request
mixedpuppy
: review+
Details
(Assignee)

Description

•
2 years ago 
We always load one when we load the other, so there's no need for the overhead of a separate JSM.
Comment hidden (mozreview-request)

Comment 2

•
2 years ago
mozreview-review 
Comment on attachment 8894700 [details]
Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm.

https://reviewboard.mozilla.org/r/165866/#review171270

::: toolkit/components/extensions/ExtensionCommon.jsm:91
(Diff revision 1)
>    [Symbol.iterator]() {
>      return this.unwrappedValues[Symbol.iterator]();
>    }
>  }
>  
> +class ExtensionAPI extends ExtensionUtils.EventEmitter {

Why is this extending the EventEmitter now, nothing else seems to have changed about the code?
 (Assignee)

Comment 3

•
2 years ago
mozreview-review-reply 
Comment on attachment 8894700 [details]
Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm.

https://reviewboard.mozilla.org/r/165866/#review171270

> Why is this extending the EventEmitter now, nothing else seems to have changed about the code?

This is on top of bug 1387898. Reviewboard just sucks.

Comment 4

•
2 years ago
mozreview-review 
Comment on attachment 8894700 [details]
Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm.

https://reviewboard.mozilla.org/r/165866/#review171280
Attachment #8894700 - Flags: review?(mixedpuppy) → review+
 (Assignee)

Comment 5

•
2 years ago 
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f7aa77d3ac9b57d1718a7d855d39c491a2ce35b
Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm. r=mixedpuppy

Comment 7

•
2 years ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/6f7aa77d3ac9
https://hg.mozilla.org/mozilla-central/rev/eefbc4d0360e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
 (Assignee)

Updated

•
2 years ago
Blocks: 1373418

Updated

•
8 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.