Status
()
People
(Reporter: kmag, Assigned: kmag)
Tracking
(Blocks: 2 bugs)
Firefox Tracking Flags
(firefox57 fixed)
Details
MozReview Requests
()
| Submitter | Diff | Changes | Open Issues | Last Updated |
|---|---|---|---|---|
| Loading... | ||||
| Error loading review requests: | ||||
Attachments
(1 attachment)
We always load one when we load the other, so there's no need for the overhead of a separate JSM.
| Comment hidden (mozreview-request) |
|
||
Comment 2•11 months ago
|
||
| mozreview-review | ||
Comment on attachment 8894700 [details] Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm. https://reviewboard.mozilla.org/r/165866/#review171270 ::: toolkit/components/extensions/ExtensionCommon.jsm:91 (Diff revision 1) > [Symbol.iterator]() { > return this.unwrappedValues[Symbol.iterator](); > } > } > > +class ExtensionAPI extends ExtensionUtils.EventEmitter { Why is this extending the EventEmitter now, nothing else seems to have changed about the code?
|
(Assignee) | |
Comment 3•11 months ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8894700 [details] Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm. https://reviewboard.mozilla.org/r/165866/#review171270 > Why is this extending the EventEmitter now, nothing else seems to have changed about the code? This is on top of bug 1387898. Reviewboard just sucks.
|
||
Comment 4•11 months ago
|
||
| mozreview-review | ||
Comment on attachment 8894700 [details] Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm. https://reviewboard.mozilla.org/r/165866/#review171280
Attachment #8894700 -
Flags: review?(mixedpuppy) → review+
|
|
(Assignee) | |
Comment 5•10 months ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f7aa77d3ac9b57d1718a7d855d39c491a2ce35b Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm. r=mixedpuppy
|
|
(Assignee) | |
Comment 6•10 months ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/eefbc4d0360e2e439d9c5c93cff981bd04171642 Bug 1388211: Follow-up: Fix merge bustage.
|
||
Comment 7•10 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6f7aa77d3ac9 https://hg.mozilla.org/mozilla-central/rev/eefbc4d0360e
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•