Closed
Bug 1388211
Opened 6 years ago
Closed 6 years ago
Fold ExtensionAPI.jsm into ExtensionCommon.jsm
Categories
(WebExtensions :: General, enhancement)
WebExtensions
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
We always load one when we load the other, so there's no need for the overhead of a separate JSM.
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8894700 [details] Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm. https://reviewboard.mozilla.org/r/165866/#review171270 ::: toolkit/components/extensions/ExtensionCommon.jsm:91 (Diff revision 1) > [Symbol.iterator]() { > return this.unwrappedValues[Symbol.iterator](); > } > } > > +class ExtensionAPI extends ExtensionUtils.EventEmitter { Why is this extending the EventEmitter now, nothing else seems to have changed about the code?
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8894700 [details] Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm. https://reviewboard.mozilla.org/r/165866/#review171270 > Why is this extending the EventEmitter now, nothing else seems to have changed about the code? This is on top of bug 1387898. Reviewboard just sucks.
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8894700 [details] Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm. https://reviewboard.mozilla.org/r/165866/#review171280
Attachment #8894700 -
Flags: review?(mixedpuppy) → review+
Assignee | ||
Comment 5•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f7aa77d3ac9b57d1718a7d855d39c491a2ce35b Bug 1388211: Fold ExtensionAPI.jsm into ExtensionCommon.jsm. r=mixedpuppy
Assignee | ||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/eefbc4d0360e2e439d9c5c93cff981bd04171642 Bug 1388211: Follow-up: Fix merge bustage.
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6f7aa77d3ac9 https://hg.mozilla.org/mozilla-central/rev/eefbc4d0360e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•5 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•