1388247 - Label PCookieServiceChild

Status: RESOLVED INVALID

(Core :: Networking: Cookies, enhancement, P3)

Description

[Kershaw Chang [:kershaw]]

Since we have bug 1331680 landed, we now have lots of runnables in PCookieServiceChild need to be labeled.

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Use SystemGroup to label PCookieServiceChild

Since CookieServiceChild is shared for all documents in the same content process, it seems we can only label CookieServiceChild as SystemGroup.

Josh, please take a look. Thanks.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Use SystemGroup to label PCookieServiceChild, r=jdm

Carry r+.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6761e3cfd323
Use SystemGroup to label PCookieServiceChild. r=jdm

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6761e3cfd323

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

Reopen because this was rolled back per bug 1398420 comment 0.

Comment 7

[Firefox Bug Husbandry Bot]

Bulk priority update: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 8

[Kershaw Chang [:kershaw]]

I'll mark this to P2 for now.

Comment 9

[Shian-Yow Wu [:swu]]

Marking as fix-optional for 57, still nice to have it if we found a good way to fix it.

Comment 10

[Andrea Marchesini [:baku]]

Farre, do we still care about labeling IPC methods?

Comment 11

[Andreas Farre [:farre]]

The only user of the labels (that I know of) is about:performance, and that only ever care about DocGroups and not SystemGroups, so this patch should be safe to drop.

Comment 12

[Andrea Marchesini [:baku]]

Based on comment 11, we can close this bug.