1388266 - Console error when no _locales dir in unpacked extension

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P3)

Description

[Dietrich Ayala (:dietrich)]

Attachment: Screen Shot 2017-08-08 at 15.53.45.png

Screenshot attached

Comment 1

[Andy McKay]

I got this too. Things still seemed to work though.

Comment 3

[Rob Wu [:robwu]]

This is a regression in 56, caused by bug 1364768.

Patch is simple. Is logspam a good reason to request a merge to beta?

Comment 4

[Rob Wu [:robwu]]

Attachment: Bug 1388266 - Ignore error about non-existing _locale and localization directory

Review commit: https://reviewboard.mozilla.org/r/177368/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177368/

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8905566 [details]
Bug 1388266 - Ignore error about non-existing _locale and localization directory

https://reviewboard.mozilla.org/r/177368/#review182442

::: toolkit/components/extensions/Extension.jsm:397
(Diff revision 1)
>            results.push(entry);
>          });
>        } catch (e) {
>          // Always return a list, even if the directory does not exist (or is
>          // not a directory) for symmetry with the ZipReader behavior.
> +        if (!(e instanceof OS.File.Error && e.becauseNoSuchFile)) {

No need for the instanceof check. Just `!e.becauseNoSuchFile`

Comment 6

[Rob Wu [:robwu]]

Comment on attachment 8905566 [details]
Bug 1388266 - Ignore error about non-existing _locale and localization directory

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177368/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81a4056d2031
Ignore error about non-existing _locale and localization directory r=kmag

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/81a4056d2031

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 10

[Rob Wu [:robwu]]

Comment on attachment 8905566 [details]
Bug 1388266 - Ignore error about non-existing _locale and localization directory

Approval Request Comment
[Feature/Bug causing the regression]: bug 1364768
[User impact if declined]: An error message appears in the console when the user loads a temporary add-on at about:debugging.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes, load a temporary add-on at about:debugging and look at the console - the reported error message does not show up any more.
[Needs manual test from QE? If yes, steps to reproduce]: Not needed.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is a small patch that suppresses one error message without other functional or logical changes.
[String changes made/needed]: N/A

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8905566 [details]
Bug 1388266 - Ignore error about non-existing _locale and localization directory

Fix an error related to extension. Beta56+.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6e0e2f09610e

Comment 13

[Cornel Ionce [:noni]]

(In reply to Rob Wu [:robwu] from comment #10)
> [Needs manual test from QE? If yes, steps to reproduce]: Not needed.
Setting qe-verify flag to -, per Rob's assessment on manual testing needs.