Closed
Bug 1388266
Opened 7 years ago
Closed 7 years ago
Console error when no _locales dir in unpacked extension
Categories
(WebExtensions :: General, defect, P3)
Tracking
(firefox-esr52 unaffected, firefox55 unaffected, firefox56 fixed, firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | fixed |
firefox57 | --- | fixed |
People
(Reporter: dietrich, Assigned: robwu)
References
Details
(Keywords: regression)
Attachments
(2 files)
54.05 KB,
image/png
|
Details | |
59 bytes,
text/x-review-board-request
|
kmag
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
Screenshot attached
Updated•7 years ago
|
Summary: error when no local dir → error when no locale dir
Updated•7 years ago
|
Summary: error when no locale dir → Console error when no _locales dir in unpacked extension
Assignee | ||
Comment 3•7 years ago
|
||
This is a regression in 56, caused by bug 1364768. Patch is simple. Is logspam a good reason to request a merge to beta?
Assignee: nobody → rob
status-firefox55:
--- → unaffected
status-firefox56:
--- → affected
status-firefox57:
--- → affected
Keywords: regression
See Also: → 1364768
Version: unspecified → 56 Branch
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8905566 [details] Bug 1388266 - Ignore error about non-existing _locale and localization directory https://reviewboard.mozilla.org/r/177368/#review182442 ::: toolkit/components/extensions/Extension.jsm:397 (Diff revision 1) > results.push(entry); > }); > } catch (e) { > // Always return a list, even if the directory does not exist (or is > // not a directory) for symmetry with the ZipReader behavior. > + if (!(e instanceof OS.File.Error && e.becauseNoSuchFile)) { No need for the instanceof check. Just `!e.becauseNoSuchFile`
Attachment #8905566 -
Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request) |
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/81a4056d2031 Ignore error about non-existing _locale and localization directory r=kmag
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/81a4056d2031
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 9•7 years ago
|
||
Please request Beta approval on this when you get a chance.
status-firefox-esr52:
--- → unaffected
Flags: needinfo?(rob)
Assignee | ||
Comment 10•7 years ago
|
||
Comment on attachment 8905566 [details] Bug 1388266 - Ignore error about non-existing _locale and localization directory Approval Request Comment [Feature/Bug causing the regression]: bug 1364768 [User impact if declined]: An error message appears in the console when the user loads a temporary add-on at about:debugging. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: Yes, load a temporary add-on at about:debugging and look at the console - the reported error message does not show up any more. [Needs manual test from QE? If yes, steps to reproduce]: Not needed. [List of other uplifts needed for the feature/fix]: N/A [Is the change risky?]: No [Why is the change risky/not risky?]: This is a small patch that suppresses one error message without other functional or logical changes. [String changes made/needed]: N/A
Flags: needinfo?(rob)
Attachment #8905566 -
Flags: approval-mozilla-beta?
Comment 11•7 years ago
|
||
Comment on attachment 8905566 [details] Bug 1388266 - Ignore error about non-existing _locale and localization directory Fix an error related to extension. Beta56+.
Attachment #8905566 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 12•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/6e0e2f09610e
Comment 13•7 years ago
|
||
(In reply to Rob Wu [:robwu] from comment #10) > [Needs manual test from QE? If yes, steps to reproduce]: Not needed. Setting qe-verify flag to -, per Rob's assessment on manual testing needs.
Flags: qe-verify-
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•