1388335 - Content-type with +json is treated as binary file, firefox is not rendering as json instead asking to download

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect, P3)

Description

[santoshjram]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce:

Send content-type as application/vnd.api+json or any other content type with suffix +json - according to rfc6839 (firefox 55 in mac 10.12.6)


Actual results:

firefox will prompt for downloading the file


Expected results:

As per https://tools.ietf.org/html/rfc6839#section-3.1 - this should be rendered as json....chrome is treating it promptly.

Comment 1

[Oriol Brufau [:Oriol]]

I already suggested load the JSON Viewer for all +json suffixes in bug 1384842 comment 1.
I did not know rfc6839, it makes even more sense with that.
This would fix bug 1384842 and bug 1258906.

Comment 4

[Oriol Brufau [:Oriol]]

Attachment: Bug 1388335 - Load JSON Viewer for all application/*+json content types.

Review commit: https://reviewboard.mozilla.org/r/192058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192058/

Comment 5

[Oriol Brufau [:Oriol]]

Is there some way to access to original content type in the content process? The code would be simpler with this.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me) PTO July 8 - 26]

Comment on attachment 8921079 [details]
Bug 1388335 - Load JSON Viewer for all application/*+json content types.

https://reviewboard.mozilla.org/r/192058/#review198522

> Is there some way to access to original content type in the content process? The code would be simpler with this.

I don't know (you can ask on IRC #developers), but the patch looks ok to me.
R+ assuming try is green
Honza

Comment 7

[Oriol Brufau [:Oriol]]

(In reply to Jan Honza Odvarko [:Honza] from comment #6)
> I don't know (you can ask on IRC #developers), but the patch looks ok to me.

OK, let's fix this first, and if there is some way the code can be simplified in another bug.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21ed15658978
Load JSON Viewer for all application/*+json content types. r=Honza

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/21ed15658978