1388354 - Optimize ToPropertyKey a bit

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

This patch adds a fast path for primitives to ToPropertyKey and moves the less-interesting object case to ToPropertyKeySlow. It eliminates some rooting overhead and is a small win on some SETELEM micro-benchmarks I tried (but it's noisy).

Comment 1

[André Bargull [:anba]]

Comment on attachment 8894870 [details] [diff] [review]
Patch

Review of attachment 8894870 [details] [diff] [review]:
-----------------------------------------------------------------

I guess, similar to the other bugs, MOZ_ALWAYS_INLINE is also necessary here, because otherwise the compiler doesn't inline the function?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/973ca5df0887
Optimize ToPropertyKey a bit. r=anba

Comment 3

[Jan de Mooij [:jandem]]

(In reply to André Bargull from comment #1)
> I guess, similar to the other bugs, MOZ_ALWAYS_INLINE is also necessary
> here, because otherwise the compiler doesn't inline the function?

The compiler (at least GCC on Linux) did not inline it without my changes. I like to add MOZ_ALWAYS_INLINE to non-trivial but hot functions that I think should be inlined to ensure all compilers at least agree on this.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/973ca5df0887