1388372 - Fix assert and null check properly to account for the pass-through mode in gUM

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Paul Adenot (:padenot)]

null-ed here [0] if the right constraints are set.

[0]: http://searchfox.org/mozilla-central/source/dom/media/webrtc/MediaEngineWebRTCAudio.cpp#399

Comment 1

[Paul Adenot (:padenot)]

Attachment: test-file.html

Comment 2

[Paul Adenot (:padenot)]

https://crash-stats.mozilla.com/signature/?product=Firefox&signature=mozilla%3A%3AMediaEngineWebRTCMicrophoneSource%3A%3AStart, all reports by me just now.

Comment 3

[Paul Adenot (:padenot)]

Attachment: 1388372.patch

Comment 4

[Paul Adenot (:padenot)]

This is quite recent, from bug 1372247, only present in current beta and nightly, and we're right at the start of the cycle.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

nullptr only, so not a sec issue

Comment 6

[Paul Adenot (:padenot)]

Attachment: patch + crashtest

Comment 7

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56872eb4e342150fddb7ae82b5c7156f07642a51

Comment 8

[Paul Adenot (:padenot)]

Comment on attachment 8894962 [details] [diff] [review]
patch + crashtest

Approval Request Comment
[Feature/Bug causing the regression]: 1330360 
[User impact if declined]: content process crash
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: just landed in nightly
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: it's just a nullcheck
[String changes made/needed]: none

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing own crashtest, at least on OS X and Android:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3eb6f350efc46346b7b2df48c820057d2eb8f6b9

Push which ran failing tests: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ee77b27b55e4d743b801514ea7d76a652f161873&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=121959337&repo=mozilla-inbound

04:05:38     INFO - REFTEST TEST-START | file:///Users/cltbld/tasks/task_1502276576/build/tests/reftest/tests/dom/media/test/crashtests/1388372.html
04:05:38     INFO - REFTEST INFO | SET PREFERENCE pref(media.navigator.permission.disabled,true)
04:05:38     INFO - REFTEST TEST-LOAD | file:///Users/cltbld/tasks/task_1502276576/build/tests/reftest/tests/dom/media/test/crashtests/1388372.html | 553 / 3258 (16%)
04:10:38     INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/tasks/task_1502276576/build/tests/reftest/tests/dom/media/test/crashtests/1388372.html | load failed: timed out waiting for reftest-wait to be removed

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef86fe4304ee
Fix assert and null check properly to account for the pass-through mode in gUM. r=jesup

Comment 11

[Paul Adenot (:padenot)]

re-pushed with fake: true in the crashtest's getUserMedia request, for machines that don't have input devices (osx, android).

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ef86fe4304ee

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8894962 [details] [diff] [review]
patch + crashtest

Crash fix, includes a test fix. OK for beta uplift.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/220da0b3e32d

Comment 15

[Andrei Vaida [:avaida]]

(In reply to Paul Adenot (:padenot) from comment #8)
> [Is this code covered by automated tests?]: yes
> [Has the fix been verified in Nightly?]: just landed in nightly
> [Needs manual test from QE? If yes, steps to reproduce]: no

Setting qe-verify- based on Paul's assessment on manual testing needs and the fact that this fix has automated coverage.