Fix assert and null check properly to account for the pass-through mode in gUM

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: padenot, Assigned: padenot)

Tracking

({csectype-nullptr})

Trunk
mozilla57
csectype-nullptr
Points:
---
Bug Flags:
in-testsuite +
qe-verify -

Firefox Tracking Flags

(firefox56 fixed, firefox57 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

a year ago
null-ed here [0] if the right constraints are set.

[0]: http://searchfox.org/mozilla-central/source/dom/media/webrtc/MediaEngineWebRTCAudio.cpp#399
(Assignee)

Updated

a year ago
Assignee: nobody → padenot
Group: core-security
(Assignee)

Comment 1

a year ago
Created attachment 8894889 [details]
test-file.html
(Assignee)

Comment 3

a year ago
Created attachment 8894893 [details] [diff] [review]
1388372.patch
Attachment #8894893 - Flags: review?(rjesup)
Attachment #8894893 - Flags: review?(rjesup) → review+
(Assignee)

Comment 4

a year ago
This is quite recent, from bug 1372247, only present in current beta and nightly, and we're right at the start of the cycle.
Keywords: csectype-nullptr
nullptr only, so not a sec issue
(Assignee)

Comment 6

a year ago
Created attachment 8894962 [details] [diff] [review]
patch + crashtest
Attachment #8894889 - Attachment is obsolete: true
Attachment #8894893 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
status-firefox56: --- → affected
Group: core-security
(Assignee)

Comment 8

a year ago
Comment on attachment 8894962 [details] [diff] [review]
patch + crashtest

Approval Request Comment
[Feature/Bug causing the regression]: 1330360 
[User impact if declined]: content process crash
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: just landed in nightly
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: it's just a nullcheck
[String changes made/needed]: none
Attachment #8894962 - Flags: approval-mozilla-beta?
Backed out for failing own crashtest, at least on OS X and Android:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3eb6f350efc46346b7b2df48c820057d2eb8f6b9

Push which ran failing tests: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ee77b27b55e4d743b801514ea7d76a652f161873&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=121959337&repo=mozilla-inbound

04:05:38     INFO - REFTEST TEST-START | file:///Users/cltbld/tasks/task_1502276576/build/tests/reftest/tests/dom/media/test/crashtests/1388372.html
04:05:38     INFO - REFTEST INFO | SET PREFERENCE pref(media.navigator.permission.disabled,true)
04:05:38     INFO - REFTEST TEST-LOAD | file:///Users/cltbld/tasks/task_1502276576/build/tests/reftest/tests/dom/media/test/crashtests/1388372.html | 553 / 3258 (16%)
04:10:38     INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/tasks/task_1502276576/build/tests/reftest/tests/dom/media/test/crashtests/1388372.html | load failed: timed out waiting for reftest-wait to be removed
Flags: needinfo?(padenot)

Comment 10

a year ago
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef86fe4304ee
Fix assert and null check properly to account for the pass-through mode in gUM. r=jesup
(Assignee)

Comment 11

a year ago
re-pushed with fake: true in the crashtest's getUserMedia request, for machines that don't have input devices (osx, android).
Flags: needinfo?(padenot)

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ef86fe4304ee
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: affected → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment on attachment 8894962 [details] [diff] [review]
patch + crashtest

Crash fix, includes a test fix. OK for beta uplift.
Attachment #8894962 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 14

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/220da0b3e32d
status-firefox56: affected → fixed
(In reply to Paul Adenot (:padenot) from comment #8)
> [Is this code covered by automated tests?]: yes
> [Has the fix been verified in Nightly?]: just landed in nightly
> [Needs manual test from QE? If yes, steps to reproduce]: no

Setting qe-verify- based on Paul's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.