Closed Bug 1388372 Opened 5 years ago Closed 5 years ago
Fix assert and null check properly to account for the pass-through mode in g
null-ed here  if the right constraints are set. : http://searchfox.org/mozilla-central/source/dom/media/webrtc/MediaEngineWebRTCAudio.cpp#399
Assignee: nobody → padenot
Attachment #8894893 - Flags: review?(rjesup) → review+
This is quite recent, from bug 1372247, only present in current beta and nightly, and we're right at the start of the cycle.
nullptr only, so not a sec issue
Comment on attachment 8894962 [details] [diff] [review] patch + crashtest Approval Request Comment [Feature/Bug causing the regression]: 1330360 [User impact if declined]: content process crash [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: just landed in nightly [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: it's just a nullcheck [String changes made/needed]: none
Attachment #8894962 - Flags: approval-mozilla-beta?
Backed out for failing own crashtest, at least on OS X and Android: https://hg.mozilla.org/integration/mozilla-inbound/rev/3eb6f350efc46346b7b2df48c820057d2eb8f6b9 Push which ran failing tests: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ee77b27b55e4d743b801514ea7d76a652f161873&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=121959337&repo=mozilla-inbound 04:05:38 INFO - REFTEST TEST-START | file:///Users/cltbld/tasks/task_1502276576/build/tests/reftest/tests/dom/media/test/crashtests/1388372.html 04:05:38 INFO - REFTEST INFO | SET PREFERENCE pref(media.navigator.permission.disabled,true) 04:05:38 INFO - REFTEST TEST-LOAD | file:///Users/cltbld/tasks/task_1502276576/build/tests/reftest/tests/dom/media/test/crashtests/1388372.html | 553 / 3258 (16%) 04:10:38 INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/tasks/task_1502276576/build/tests/reftest/tests/dom/media/test/crashtests/1388372.html | load failed: timed out waiting for reftest-wait to be removed
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ef86fe4304ee Fix assert and null check properly to account for the pass-through mode in gUM. r=jesup
re-pushed with fake: true in the crashtest's getUserMedia request, for machines that don't have input devices (osx, android).
Comment on attachment 8894962 [details] [diff] [review] patch + crashtest Crash fix, includes a test fix. OK for beta uplift.
Attachment #8894962 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Paul Adenot (:padenot) from comment #8) > [Is this code covered by automated tests?]: yes > [Has the fix been verified in Nightly?]: just landed in nightly > [Needs manual test from QE? If yes, steps to reproduce]: no Setting qe-verify- based on Paul's assessment on manual testing needs and the fact that this fix has automated coverage.
You need to log in before you can comment on or make changes to this bug.