1388391 - Track DOMError usage with telemetry

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

We want to get rid of DOMError (bug 1120178).  Let's see if it's used infrequently enough.  We should track calls to the constructor, which will throw if removed; and to .name and .message, because those behave differently for DOMException.

The natural thing to track all this would be use counters, but those don't seem to currently support tracking constructor calls.  Thus I'll block this on bug 1175033.

Comment 1

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Attachment: Bug 1388391 - Track DOMError usage with telemetry;

Review commit: https://reviewboard.mozilla.org/r/168016/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168016/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8896720 [details]
Bug 1388391 - Track DOMError usage with telemetry;

https://reviewboard.mozilla.org/r/168016/#review173416

::: dom/base/DOMError.cpp:72
(Diff revision 1)
>                        ErrorResult& aRv)
>  {
>    nsCOMPtr<nsPIDOMWindowInner> window = do_QueryInterface(aGlobal.GetAsSupports());
>  
> +  if (window) {
> +    nsCOMPtr<nsIDocument> doc = window->GetDoc();

GetExtantDoc

Comment 3

[François Marier [:francois]]

Comment on attachment 8896720 [details]
Bug 1388391 - Track DOMError usage with telemetry;

https://reviewboard.mozilla.org/r/168016/#review174178

This is [Category 1](https://wiki.mozilla.org/Firefox/Data_Collection#Data_Collection_Categories) data.

datareview+

Comment 4

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Comment on attachment 8896720 [details]
Bug 1388391 - Track DOMError usage with telemetry;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168016/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/417e576cfa1e
Track DOMError usage with telemetry; r=francois,smaug

Comment 6

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

I accidentally landed the version without the GetDoc -> GetExtantDoc fix.  I'm trying to get someone to back it out or push a followup.

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17c3cd3b69b6
Backed out changeset 417e576cfa1e on developers request

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79823f111dab
Track DOMError usage with telemetry; r=francois,smaug

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/79823f111dab