Remove fast animation and tip panel code from customize mode

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Toolbars and Customization
P1
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: Gijs, Assigned: mikedeboer)

Tracking

55 Branch
Firefox 57
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [reserve-photon-structure])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

3 months ago
The CSS and uses in CustomizeMode.jsm were removed, but not gDisableAnimation and the corresponding setter code in tests.

Likewise, the customize tip panel will now never be shown, but seems to still be present in markup.
(Reporter)

Updated

3 months ago
Flags: qe-verify-
Priority: -- → P3
Whiteboard: [reserve-photon-structure]
Assignee: nobody → me

Updated

3 months ago
Status: NEW → ASSIGNED
Priority: P3 → P1
This is an assigned P1 bug without activity in two weeks. 

If you intend to continue working on this bug for the current release/iteration/sprint, remove the 'stale-bug' keyword.

Otherwise we'll reset the priority of the bug back to '--' on Monday, August 28th.
Keywords: stale-bug
(Reporter)

Updated

3 months ago
Keywords: stale-bug
Unassigning myself as there has been no recent action from my side and I don't see myself doing any action on this for the next few weeks.

Sorry about this, if somebody wants to take this, go for it! :)
Assignee: me → nobody
Status: ASSIGNED → NEW

Updated

3 months ago
Priority: P1 → P3
(Reporter)

Updated

2 months ago
Priority: P3 → P4
(Reporter)

Updated

2 months ago
Priority: P4 → P5
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Reporter)

Comment 5

2 months ago
mozreview-review
Comment on attachment 8910253 [details]
Bug 1388422 - Remove all traces of the Customize Mode tip panel that no longer applies.

https://reviewboard.mozilla.org/r/181746/#review187078

Woop!
Attachment #8910253 - Flags: review?(gijskruitbosch+bugs) → review+
(Reporter)

Comment 6

2 months ago
mozreview-review
Comment on attachment 8910252 [details]
Bug 1388422 - Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests.

https://reviewboard.mozilla.org/r/181744/#review187080
Attachment #8910252 - Flags: review?(gijskruitbosch+bugs) → review+

Updated

2 months ago
Iteration: --- → 57.3 - Sep 19
Priority: P5 → P1

Comment 7

2 months ago
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3440f3e480eb
Clean up all traces of the 'browser.uiCustomization.disableAnimation' pref used to disable Customize Mode transitions in unit tests. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/5a1251678a2c
Remove all traces of the Customize Mode tip panel that no longer applies. r=Gijs

Comment 8

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3440f3e480eb
https://hg.mozilla.org/mozilla-central/rev/5a1251678a2c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.