1388456 - Show the ping selector popup next to the ping chooser button in about:telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[flyingrub]

Right now the popup is shown in the upper right corner to leave space for the content but it is confusing for the user to understand that the appearance of the the ping selection button is related to the action on the button.

Comment 1

[flyingrub]

Attachment: Bug 1388456 - Make the ping selection in about:telemetry clearer

Show the ping selector popup next to its toggle button in
about:telemetry.

Review commit: https://reviewboard.mozilla.org/r/166270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166270/

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8895142 [details]
Bug 1388456 - Make the ping selection in about:telemetry clearer

https://reviewboard.mozilla.org/r/166270/#review171790

Lets show the dialog right below the ping selector button.
Together with bug 1385351, this will make it behave more like a standard drop-down dialog.

Comment 3

[flyingrub]

Comment on attachment 8895142 [details]
Bug 1388456 - Make the ping selection in about:telemetry clearer

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166270/diff/1-2/

Comment 4

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8895142 [details]
Bug 1388456 - Make the ping selection in about:telemetry clearer

https://reviewboard.mozilla.org/r/166270/#review172292

Comment 5

[flyingrub]

Comment on attachment 8895142 [details]
Bug 1388456 - Make the ping selection in about:telemetry clearer

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166270/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b356aa6fa0ef
Make the ping selection in about:telemetry clearer r=gfritzsche

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b356aa6fa0ef