1388554 - "Recently Closed" History panel icon is cropped

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Chenxia Liu [:liuche]]

Attachment: Screenshot: History panel cropped image

In the home panel, the icon for the "Recently Closed" tabs is cropped. On Android 5.1 phone.

Comment 1

[Max Liu [:maliu]]

Hi :jwu,

Would you help to check on this please? Thanks.

Comment 2

[Jing-wei Wu [:jwu]]

Attachment: Bug 1388554 - Adjust smart folder icon size to prevent icon cropped.

The size of smart folder icon should be identical to favicon in TwoLinePageRow.
Also change scaleType from 'center' to 'centerInside' to prevent icon cropped.

Review commit: https://reviewboard.mozilla.org/r/166418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166418/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8895253 [details]
Bug 1388554 - Adjust smart folder icon size to prevent icon cropped.

https://reviewboard.mozilla.org/r/166418/#review172604

Comment 4

[Max Liu [:maliu]]

Comment on attachment 8895253 [details]
Bug 1388554 - Adjust smart folder icon size to prevent icon cropped.

https://reviewboard.mozilla.org/r/166418/#review172612

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64e7486cf038
Adjust smart folder icon size to prevent icon cropped. r=maliu,nechen

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/64e7486cf038

Comment 7

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Frequent crash on 56

Please request Beta approval on this when you get a chance.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Sorry, wrong tab there :)

Comment 9

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed on Nightly 57 (2017-08-24).
Devices:
Xiaomi Mi Pad 2 (Android 5.1)
Oneplus Two (Android 6.0.1)
Prestigio Grace X5 (Android 4.4.2)