1388556 - Extra space above "Desktop Bookmarks" folder in Bookmarks home panel

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Bookmarks panel folder extra space

There's an extra space above the Desktop Bookmarks folder.

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: Bug 1388556 - Use different background drawables for ListView:listSelector and MenuItemActionBar:background.

action_bar_button.xml is both used in ListView:listSelector and MenuItemActionBar:background.

Because in Photon the background of menu item is changed to round rectangle with insecTop/insecBottom,
the change in action_bar_button causes ListView:listSelector has extra space.

The solution is using 2 different drwables for ListView:listSelector and MenuItemActionBar:background separately.

Review commit: https://reviewboard.mozilla.org/r/166490/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166490/

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8895293 [details]
Bug 1388556 - Use different background drawables for ListView:listSelector and MenuItemActionBar:background.

https://reviewboard.mozilla.org/r/166490/#review172606

Comment 3

[Julian Chu [:walkingice]]

Comment on attachment 8895293 [details]
Bug 1388556 - Use different background drawables for ListView:listSelector and MenuItemActionBar:background.

https://reviewboard.mozilla.org/r/166490/#review173912

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/555541c4f2f6
Use different background drawables for ListView:listSelector and MenuItemActionBar:background. r=nechen,walkingice

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/555541c4f2f6

Comment 6

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 57 (2017-08-24).
Devices:
Xiaomi Mi Pad 2 (Android 5.1)
Oneplus Two (Android 6.0.1)
Prestigio Grace X5 (Android 4.4.2)