Closed Bug 1388557 Opened 5 years ago Closed 4 years ago

We should call RequestRestyle(Layer) when we attach orphaned element which has script animations to document

Categories

(Core :: DOM: Animation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(1 file)

I did observe this while I am trying to fix bug 1379516.
See Also: → 1275466
Priority: -- → P3
See Also: → 1419851
It turned out that the test case for this bug [1] does not pass without fixing bug 1417354.

[1] https://hg.mozilla.org/mozilla-central/file/fb881aff4e4e/dom/animation/test/mozilla/file_restyles.html#l1312
Depends on: 1417354
Blocking bug 1419851, it's related more or less.
Assignee: nobody → hikezoe
Blocks: 1419851
Status: NEW → ASSIGNED
Comment on attachment 8952030 [details]
Bug 1388557 - Call RequestRestyle(Layer) in the case where we attach orphaned animating element to the document.

https://reviewboard.mozilla.org/r/221250/#review227082

Again, I'm concerned about the extra hashmap lookup but I assume MayHaveAnimations will very rarely be true in this case so it's ok.
Attachment #8952030 - Flags: review?(bbirtles) → review+
Blocks: 1439428
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c23d6d439b2
Call RequestRestyle(Layer) in the case where we attach orphaned animating element to the document. r=birtles
https://hg.mozilla.org/mozilla-central/rev/2c23d6d439b2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.