1388557 - We should call RequestRestyle(Layer) when we attach orphaned element which has script animations to document

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

I did observe this while I am trying to fix bug 1379516.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

It turned out that the test case for this bug [1] does not pass without fixing bug 1417354.

[1] https://hg.mozilla.org/mozilla-central/file/fb881aff4e4e/dom/animation/test/mozilla/file_restyles.html#l1312

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Blocking bug 1419851, it's related more or less.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1388557 - Call RequestRestyle(Layer) in the case where we attach orphaned animating element to the document.

Review commit: https://reviewboard.mozilla.org/r/221250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221250/

Comment 4

[Brian Birtles (:birtles)]

Comment on attachment 8952030 [details]
Bug 1388557 - Call RequestRestyle(Layer) in the case where we attach orphaned animating element to the document.

https://reviewboard.mozilla.org/r/221250/#review227082

Again, I'm concerned about the extra hashmap lookup but I assume MayHaveAnimations will very rarely be true in this case so it's ok.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8952030 [details]
Bug 1388557 - Call RequestRestyle(Layer) in the case where we attach orphaned animating element to the document.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221250/diff/1-2/

Comment 6

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0946516d5d4852d2e9e4a38c734924e1eb5abec

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c23d6d439b2
Call RequestRestyle(Layer) in the case where we attach orphaned animating element to the document. r=birtles

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2c23d6d439b2