Closed
Bug 1388588
Opened 9 years ago
Closed 9 years ago
Stylo: incorrect line-height when page is zoomed (using text-only zoom)
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
VERIFIED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: bgstandaert, Assigned: emilio)
References
(Blocks 1 open bug, )
Details
(Keywords: nightly-community)
Attachments
(3 files)
STR:
1. Visit https://www.nytimes.com/2017/08/08/world/asia/north-korea-un-sanctions-nuclear-missile-united-nations.html
2. Zoom page to 150%.
With stylo disabled, the line-height stays visually the same when the page is zoomed. With stylo enabled, the space between the lines increases the more the page is zoomed.
| Reporter | ||
Comment 1•9 years ago
|
||
stylo disabled
| Reporter | ||
Comment 2•9 years ago
|
||
stylo enabled
Comment 3•9 years ago
|
||
I can*t reproduce this in Nightly 57 x64 20170809100326 @ Debian Testing. :(
| Assignee | ||
Updated•9 years ago
|
Summary: Stylo: incorrect line-height when page is zoomed → Stylo: incorrect line-height when page is zoomed (using text-only zoom)
| Assignee | ||
Comment 5•9 years ago
|
||
Actually I think I found the bug on this one.
Assignee: nobody → emilio+bugs
Updated•9 years ago
|
Status: UNCONFIRMED → NEW
Has STR: --- → yes
Ever confirmed: true
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Assignee | ||
Comment 8•9 years ago
|
||
Any good way to ad tests for this stuff Manish?
Comment 9•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8895379 [details]
Bug 1388588: Only zoom absolute lengths.
https://reviewboard.mozilla.org/r/166570/#review171736
Attachment #8895379 -
Flags: review?(manishearth) → review+
Comment 10•9 years ago
|
||
I suspect mochitests *can*, but I don't think we have any that we run.
Flags: needinfo?(manishearth)
| Assignee | ||
Comment 11•9 years ago
|
||
Yeah, seems like we have chrome-only tests for this... Won't bother rewriting them, we'll get them for free when we enable stylo for chrome docs.
* https://github.com/servo/servo/pull/18022
* https://hg.mozilla.org/integration/autoland/rev/97a30295ad35
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
status-firefox57:
--- → fixed
Target Milestone: --- → mozilla57
Comment 12•9 years ago
|
||
Seen fixed in Nightly 57 x64 20170812100345 @ Debian Testing.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•