Closed Bug 1388588 Opened 7 years ago Closed 7 years ago

Stylo: incorrect line-height when page is zoomed (using text-only zoom)

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: bgstandaert, Assigned: emilio)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: nightly-community)

Attachments

(3 files)

normal.png
593.21 KB, image/png
Details
stylo.png
446.47 KB, image/png
Details
Bug 1388588: Only zoom absolute lengths.
59 bytes, text/x-review-board-request
manishearth
: review+
Details 
STR:

1. Visit https://www.nytimes.com/2017/08/08/world/asia/north-korea-un-sanctions-nuclear-missile-united-nations.html
2. Zoom page to 150%.

With stylo disabled, the line-height stays visually the same when the page is zoomed. With stylo enabled, the space between the lines increases the more the page is zoomed.
Attached image normal.png — 
stylo disabled
Attached image stylo.png — 
stylo enabled
I can*t reproduce this in Nightly 57 x64 20170809100326 @ Debian Testing. :(
Blocks: stylo-site-issues
URL: https://www.nytimes.com/2017/08/08/wo...
Keywords: nightly-community
I can repro using text-only zoom.
Flags: needinfo?(manishearth)
Summary: Stylo: incorrect line-height when page is zoomed → Stylo: incorrect line-height when page is zoomed (using text-only zoom)
Actually I think I found the bug on this one.
Assignee: nobody → emilio+bugs
Status: UNCONFIRMED → NEW
Has STR: --- → yes
Ever confirmed: true
Any good way to ad tests for this stuff Manish?
Comment on attachment 8895379 [details]
Bug 1388588: Only zoom absolute lengths.

https://reviewboard.mozilla.org/r/166570/#review171736
Attachment #8895379 - Flags: review?(manishearth) → review+
I suspect mochitests *can*, but I don't think we have any that we run.
Flags: needinfo?(manishearth)
Yeah, seems like we have chrome-only tests for this... Won't bother rewriting them, we'll get them for free when we enable stylo for chrome docs.

 * https://github.com/servo/servo/pull/18022
 * https://hg.mozilla.org/integration/autoland/rev/97a30295ad35
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
status-firefox57: --- → fixed
Target Milestone: --- → mozilla57
Seen fixed in Nightly 57 x64 20170812100345 @ Debian Testing.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: