1388612 - Remove MediaResource::EnsureCacheUpToDate()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

The method is introduced by bug 687972 to fix test case timeout. I don't think it is needed anymore for MediaCache will run the update loop whenever necessary. We don't need a call to tell MediaCache to run Update() explicitly.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Also see bug 1108960 where MediaCache failed to run the update loop to change the suspend status of the stream. Anyway, we should remove EnsureCacheUpToDate() and fix the bug in update loop if any in the future.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1388612. P1 - remove MediaResource::EnsureCacheUpToDate().

This is a workaround to fix bug 687972. It should be OK now to remove
it since we have fix bug 1108960  where MediaCache failed to run the
update loop to update the suspend status of the stream.

Review commit: https://reviewboard.mozilla.org/r/166902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166902/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1388612. P2 - remove the call to NotifySuspendedStatusChanged() in MediaDecoder::FirstFrameLoaded().

Following P1, cache suspend status changes will be notified when necessary.
If not, it would be a bug that should be fixed. We shouldn't wallpaper the
issue by calling NotifySuspendedStatusChanged() manually.

Review commit: https://reviewboard.mozilla.org/r/166904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166904/

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8895647 [details]
Bug 1388612. P1 - remove MediaResource::EnsureCacheUpToDate().

https://reviewboard.mozilla.org/r/166902/#review171996

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8895648 [details]
Bug 1388612. P2 - remove the call to NotifySuspendedStatusChanged() in MediaDecoder::FirstFrameLoaded().

https://reviewboard.mozilla.org/r/166904/#review171998

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the reviews!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad27bf79e7d7
P1 - remove MediaResource::EnsureCacheUpToDate(). r=gerald
https://hg.mozilla.org/integration/autoland/rev/f3acacadd41d
P2 - remove the call to NotifySuspendedStatusChanged() in MediaDecoder::FirstFrameLoaded(). r=gerald

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad27bf79e7d7
https://hg.mozilla.org/mozilla-central/rev/f3acacadd41d