Closed Bug 1388612 Opened 2 years ago Closed 2 years ago

Remove MediaResource::EnsureCacheUpToDate()

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

The method is introduced by bug 687972 to fix test case timeout. I don't think it is needed anymore for MediaCache will run the update loop whenever necessary. We don't need a call to tell MediaCache to run Update() explicitly.
Assignee: nobody → jwwang
Blocks: 1373160
Priority: -- → P3
See Also: → 687972
Also see bug 1108960 where MediaCache failed to run the update loop to change the suspend status of the stream. Anyway, we should remove EnsureCacheUpToDate() and fix the bug in update loop if any in the future.
Depends on: 1108960
Attachment #8895647 - Flags: review?(gsquelart)
Attachment #8895648 - Flags: review?(gsquelart)
Comment on attachment 8895647 [details]
Bug 1388612. P1 - remove MediaResource::EnsureCacheUpToDate().

https://reviewboard.mozilla.org/r/166902/#review171996
Attachment #8895647 - Flags: review?(gsquelart) → review+
Comment on attachment 8895648 [details]
Bug 1388612. P2 - remove the call to NotifySuspendedStatusChanged() in MediaDecoder::FirstFrameLoaded().

https://reviewboard.mozilla.org/r/166904/#review171998
Attachment #8895648 - Flags: review?(gsquelart) → review+
Thanks for the reviews!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad27bf79e7d7
P1 - remove MediaResource::EnsureCacheUpToDate(). r=gerald
https://hg.mozilla.org/integration/autoland/rev/f3acacadd41d
P2 - remove the call to NotifySuspendedStatusChanged() in MediaDecoder::FirstFrameLoaded(). r=gerald
https://hg.mozilla.org/mozilla-central/rev/ad27bf79e7d7
https://hg.mozilla.org/mozilla-central/rev/f3acacadd41d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.