1388681 - cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

When building with CFLAGS globally set with -Wformat -Werror=format-security, the build fails with:
cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
cc1: some warnings being treated as errors
/build/firefox-55.0/config/rules.mk:857: recipe for target 'nr_crypto.o' failed

This is because nr_crypto.o is built with an additional -Wno-format, which disables -Wformat, but that still leave the -Werror=format-security around. Apparently, gcc was happy with that mix of options... until version 7.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1388681 - Disable -Wformat-security where -Wformat is disabled.

Review commit: https://reviewboard.mozilla.org/r/166494/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166494/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8895301 [details]
Bug 1388681 - Disable -Wformat-security where -Wformat is disabled.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166494/diff/1-2/

Comment 3

[Byron Campen [:bwc]]

Comment on attachment 8895301 [details]
Bug 1388681 - Disable -Wformat-security where -Wformat is disabled.

https://reviewboard.mozilla.org/r/166494/#review171758

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ac356d68395
Disable -Wformat-security where -Wformat is disabled. r=bwc

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2ac356d68395