Closed
Bug 1388681
Opened 7 years ago
Closed 7 years ago
cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
When building with CFLAGS globally set with -Wformat -Werror=format-security, the build fails with: cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security] cc1: some warnings being treated as errors /build/firefox-55.0/config/rules.mk:857: recipe for target 'nr_crypto.o' failed This is because nr_crypto.o is built with an additional -Wno-format, which disables -Wformat, but that still leave the -Werror=format-security around. Apparently, gcc was happy with that mix of options... until version 7.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Updated•7 years ago
|
Attachment #8895301 -
Flags: review?(rjesup) → review?(docfaraday)
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8895301 [details] Bug 1388681 - Disable -Wformat-security where -Wformat is disabled. https://reviewboard.mozilla.org/r/166494/#review171758
Attachment #8895301 -
Flags: review?(docfaraday) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/2ac356d68395 Disable -Wformat-security where -Wformat is disabled. r=bwc
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2ac356d68395
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•