1388691 - In about:telemetry show the raw json ping in the firefox json viewer

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[flyingrub]

It could be usefull to display it in the firefox json viewer that is very convenient to deal with json.

Comment 1

[flyingrub]

Attachment: Bug 1388691 - Use the firefox json viewer in about:telemetry

Allow to open the full ping data in the firefox json viewer.

Review commit: https://reviewboard.mozilla.org/r/166534/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166534/

Comment 2

[flyingrub]

Comment on attachment 8895322 [details]
Bug 1388691 - Use the firefox json viewer in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166534/diff/1-2/

Comment 3

[flyingrub]

Comment on attachment 8895322 [details]
Bug 1388691 - Use the firefox json viewer in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166534/diff/2-3/

Comment 4

[flyingrub]

Comment on attachment 8895322 [details]
Bug 1388691 - Use the firefox json viewer in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166534/diff/3-4/

Comment 5

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8895322 [details]
Bug 1388691 - Use the firefox json viewer in about:telemetry

https://reviewboard.mozilla.org/r/166534/#review171804

Opening this in the Firefox JSON viewer is very convenient.
Some changes requested below though.

::: toolkit/content/aboutTelemetry.js:2042
(Diff revision 4)
> +  var data = new Blob([json], {type: "application/json"});
> +  var reader = new FileReader();
> +  reader.onloadend = (e) => window.open(reader.result)
> +  reader.readAsDataURL(data);

I think we don't need to use `Blob` or `FileReader` here, you can just do something like:
`window.open("data:application/json;base64," + btoa(json))`

::: toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd:23
(Diff revision 4)
> +<!ENTITY aboutTelemetry.showInFirefoxJsonViewer "
> +Open in the firefox JSON viewer
> +">

I don't see this being used anywhere?

Comment 6

[flyingrub]

Comment on attachment 8895322 [details]
Bug 1388691 - Use the firefox json viewer in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166534/diff/4-5/

Comment 7

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8895322 [details]
Bug 1388691 - Use the firefox json viewer in about:telemetry

https://reviewboard.mozilla.org/r/166534/#review172278

::: toolkit/content/aboutTelemetry.js:2042
(Diff revision 5)
>      }
>    }
>  }
>  
> +function openJsonInFirefoxJsonViewer(json) {
> +  window.open("data:application/json;base64," + btoa(json))

This line is missing a trailing ";".

::: toolkit/content/aboutTelemetry.xhtml:90
(Diff revision 5)
>          <span class="category-name">&aboutTelemetry.capturedStacksSection;</span>
>        </div>
>        <div class="category" value="late-writes-section">
>          <span class="category-name">&aboutTelemetry.lateWritesSection;</span>
>        </div>
> -      <div id="category-raw" class="category has-data" value="raw-ping-data-section">
> +      <div id="category-raw" class="category has-data" value="rawJSON">

Lets stay consistent with the existing naming styles, e.g. by using "open-raw-json" or similar.

Comment 8

[flyingrub]

Comment on attachment 8895322 [details]
Bug 1388691 - Use the firefox json viewer in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166534/diff/5-6/

Comment 9

[flyingrub]

Comment on attachment 8895322 [details]
Bug 1388691 - Use the firefox json viewer in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166534/diff/6-7/

Comment 10

[flyingrub]

Comment on attachment 8895322 [details]
Bug 1388691 - Use the firefox json viewer in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166534/diff/7-8/

Comment 11

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8895322 [details]
Bug 1388691 - Use the firefox json viewer in about:telemetry

https://reviewboard.mozilla.org/r/166534/#review172378

This looks good now.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Autoland can't push this until all pending issues in MozReview are marked as resolved.

Comment 13

[flyingrub]

fixed :)

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d9cf59817bb
Use the firefox json viewer in about:telemetry r=gfritzsche

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0d9cf59817bb