Restoring sessions with multiple windows is very slow

NEW
Unassigned

Status

()

defect
P3
normal
2 years ago
a year ago

People

(Reporter: florian, Unassigned)

Tracking

(Blocks 1 bug, {perf})

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix)

Details

(Whiteboard: [fxperf:p3])

Reporter

Description

2 years ago
See this profile where on a very fast macbook; restoring a session with 15 windows (14 of which contained only 1 tab with about:home) took more than 5s: https://perfht.ml/2wIrz5U

Looking at the JS code doesn't show me obvious problems. There's certainly stuff we could optimize, but it would be small wins.

Looking at the platform stuff however, there seem to be a lot of time spent with the main thread blocked on sync IPC. PLayerTransaction::Msg_GetTextureFactoryIdentifier and PCompositorBridge::Msg_FlushRendering specifically seem to account for a lot of the time.

Comment 1

2 years ago
Please add "perf" key word. Thank you.
Florian, what do you want to do with this bug? Should we move it to Core and ask IPC experts to take a look, or do you want to get a new profile and see where things stand now?
Flags: needinfo?(florian)
Keywords: perf
Reporter

Comment 3

2 years ago
(In reply to Panos Astithas [:past] (please ni?) from comment #2)
> Florian, what do you want to do with this bug? Should we move it to Core and
> ask IPC experts to take a look, or do you want to get a new profile and see
> where things stand now?

I think the profile here is likely obsolete at this point. Restoring sessions could do with performance improvements, so it may be useful to reprofile someday.
Flags: needinfo?(florian)
Priority: -- → P3

Updated

a year ago
Component: General → Session Restore
Whiteboard: [fxperf]
Whiteboard: [fxperf] → [fxperf:p3]
You need to log in before you can comment on or make changes to this bug.