Make sure all linux64-qr tests are running with HWA enabled

RESOLVED FIXED in Firefox 57

Status

()

Core
Graphics: WebRender
P3
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: kats, Assigned: kats)

Tracking

57 Branch
mozilla57
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

As of bug 1387764, WebRender will be disabled if HWA is disabled. Since Firefox on Linux has HWA disabled by default, that means WebRender is going to be disabled by default. And that in turn means all the linux64-qr test suites that don't have HWA enabled will not actually be running webrender!

We should fix this, otherwise we will basically only be left with reftest coverage (thanks to bug 1388726) and all the other suites will be running without webrender.
(Assignee)

Updated

7 months ago
Blocks: 1387764
Depends on: 1388726
We can enable HWA either by setting layers.acceleration.force-enabled to true, or setting MOZ_ACCELERATED=1. I think the latter is easier since we can just plop it wherever we are setting MOZ_WEBRENDER=1.
And actually we can stop running the "reftest-no-accel" on linux64-qr as well, because they are pointless. Either webrender will be enabled, and it'll be the same as the accelerated reftests, or webrender won't be enabled and it will be the same as the non-qr linux64 reftest-no-accel.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
@ahal: I'd have flagged jmaher for review on the first patch but he's on PTO and not accept review requests. It's a pretty simple change though.

Comment 7

7 months ago
mozreview-review
Comment on attachment 8895515 [details]
Bug 1388833 - Force-enable hardware acceleration for test suites that enable WebRender, because HWA is now a WR requirement.

https://reviewboard.mozilla.org/r/166720/#review171904

Lgtm!
Attachment #8895515 - Flags: review?(ahalberstadt) → review+
In the interest of not leaving WR testing broken for too long I'm going to land the first patch now while waiting for review on the second patch.
(Assignee)

Updated

7 months ago
Attachment #8895516 - Attachment is obsolete: true
Attachment #8895516 - Flags: review?(dustin)
(Assignee)

Updated

7 months ago
Keywords: leave-open
Version: Other Branch → 57 Branch

Comment 9

7 months ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96172895b826
Force-enable hardware acceleration for test suites that enable WebRender, because HWA is now a WR requirement. r=ahal
Created attachment 8895800 [details] [diff] [review]
Stop running reftest-no-accel on linux64-qr builds because they are redundant
Attachment #8895800 - Flags: review?(dustin)
(Assignee)

Updated

7 months ago
Attachment #8895515 - Flags: checkin+
Attachment #8895800 - Flags: review?(dustin) → review+

Comment 11

7 months ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e1d0438c31b
Stop running reftest-no-accel on linux64-qr builds because they are redundant. r=dustin
(Assignee)

Updated

7 months ago
Keywords: leave-open

Comment 13

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4e1d0438c31b
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.