1388866 - Make meta values AccessibilityInProcClient and AccessibilityClient available for faceting/search

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Jim Mathies [:jimm]]

I'd like to be able to facet on two new meta report values - 

AccessibilityInProcClient
AccessibilityClient

Comment 1

[Jim Mathies [:jimm]]

Hey Chris, can you help get this into someone's work queue?

Comment 2

[Peter Bengtsson [:peterbe]]

Hi Jim,
Sorry for slow response. Our staging server has been a yo-yo with lots of recent breaking changes. 

I'm taking over the "management" of adding new SuperSearch fields so I need to be careful that I'm doing this right. 

1. Can you provide some examples of crashes that have these values?

2. What type is its value? (might become obvious once I see some sample crashes)

3. Do you have a description for these fields? Not strictly necessary but a great opportunity to take notes for the future. Also, if we're ever going to send these values over to the Telemetry platform we need descriptions for both fields.

Comment 3

[Peter Bengtsson [:peterbe]]

note-to-self; https://crash-stats.allizom.org/admin/supersearch-field/?full_name=raw_crash.AccessibilityClient & https://crash-stats.allizom.org/admin/supersearch-field/?full_name=raw_crash.AccessibilityInProcClient

Comment 4

[Jim Mathies [:jimm]]

(In reply to Peter Bengtsson [:peterbe] from comment #2)
> 1. Can you provide some examples of crashes that have these values?
> 
> 2. What type is its value? (might become obvious once I see some sample
> crashes)

AccessibilityInProcClient:
https://crash-stats.mozilla.com/report/index/e6b8f96d-cf95-41ef-8b4b-ab3e70170815#tab-metadata

(hex value printed to a string)

AccessibilityClient:
https://crash-stats.mozilla.com/report/index/20e25952-7271-44da-8e0a-816260170815#tab-metadata

(string value)

> 
> 3. Do you have a description for these fields? Not strictly necessary but a
> great opportunity to take notes for the future. Also, if we're ever going to
> send these values over to the Telemetry platform we need descriptions for
> both fields.


AccessibilityInProcClient - "In-process accessibility client detection information. See Compatibility.h for more details."

AccessibilityClient - "Out-of-process accessibility client program name and version information."

Comment 5

[Peter Bengtsson [:peterbe]]

Done on stage. 

Compare
https://crash-stats.allizom.org/report/index/20e25952-7271-44da-8e0a-816260170815#tab-metadata and https://crash-stats.mozilla.com/report/index/20e25952-7271-44da-8e0a-816260170815#tab-metadata
In stage, AccessibilityClient and AccessibilityInProcClient appears.

Can you please check that you can do the kind of SuperSearch queries and facetting you want to using our staging server?

E.g.  https://crash-stats.allizom.org/search/?accessibility_in_proc_client=0x400&product=Firefox&date=%3E%3D2017-08-08T17%3A04%3A00.000Z&date=%3C2017-08-15T17%3A04%3A00.000Z&_sort=-date&_facets=accessibility_in_proc_client&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-accessibility_in_proc_client

Comment 6

[Jim Mathies [:jimm]]

(In reply to Peter Bengtsson [:peterbe] from comment #5)
> Done on stage. 
> 
> Compare
> https://crash-stats.allizom.org/report/index/20e25952-7271-44da-8e0a-
> 816260170815#tab-metadata and
> https://crash-stats.mozilla.com/report/index/20e25952-7271-44da-8e0a-
> 816260170815#tab-metadata
> In stage, AccessibilityClient and AccessibilityInProcClient appears.
> 
> Can you please check that you can do the kind of SuperSearch queries and
> facetting you want to using our staging server?
> 
> E.g. 
> https://crash-stats.allizom.org/search/
> ?accessibility_in_proc_client=0x400&product=Firefox&date=%3E%3D2017-08-
> 08T17%3A04%3A00.000Z&date=%3C2017-08-15T17%3A04%3A00.000Z&_sort=-
> date&_facets=accessibility_in_proc_client&_columns=date&_columns=signature&_c
> olumns=product&_columns=version&_columns=build_id&_columns=platform#facet-
> accessibility_in_proc_client

Looks great!

https://crash-stats.allizom.org/search/?product=Firefox&date=%3E%3D2017-08-08T17%3A04%3A00.000Z&date=%3C2017-08-15T17%3A04%3A00.000Z&_sort=-date&_facets=accessibility_in_proc_client&_facets=accessibility_client&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-accessibility_client

Comment 7

[Peter Bengtsson [:peterbe]]

Done in prod too.
https://crash-stats.mozilla.com/search/?product=Firefox&date=%3E%3D2017-08-09T13%3A50%3A00.000Z&date=%3C2017-08-16T13%3A50%3A00.000Z&_sort=-date&_facets=accessibility_client&_facets=accessibility_in_proc_client&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-accessibility_client

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

This is really great info to have. Will these eventually show up in the crash report Correlations tab?
e.g. https://crash-stats.mozilla.com/signature/?build_id=%3E20170821000000&product=Firefox&_sort=-date&version=57.0a1&signature=IPCError-browser%20%7C%20PBrowserParent%3A%3ARecvPDocAccessibleConstructor%20Constructing%20a%20top-level%20PDocAccessible%20with%20null%20COM&date=%3E%3D2017-08-19T12%3A44%3A45.000Z&date=%3C2017-08-22T12%3A44%3A45.000Z#correlations

Comment 9

[Peter Bengtsson [:peterbe]]

(In reply to David Bolter [:davidb] (NeedInfo me for attention) from comment #8)
> This is really great info to have. Will these eventually show up in the
> crash report Correlations tab?
> e.g.
> https://crash-stats.mozilla.com/signature/
> ?build_id=%3E20170821000000&product=Firefox&_sort=-date&version=57.
> 0a1&signature=IPCError-
> browser%20%7C%20PBrowserParent%3A%3ARecvPDocAccessibleConstructor%20Construct
> ing%20a%20top-level%20PDocAccessible%20with%20null%20COM&date=%3E%3D2017-08-
> 19T12%3A44%3A45.000Z&date=%3C2017-08-22T12%3A44%3A45.000Z#correlations

If that question was directed to me, I'm sorry I don't know. 
The correlations are now calculated in Redash (sort of) and exported and then pulled into Crash-stats. 
Marco Caste

Comment 10

[Peter Bengtsson [:peterbe]]

(sorry, managed to submit the form prematurely)

Marco Castelluccio knows better.