1388881 - stylo: Respect mathml.disabled

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Manish Goregaokar [:manishearth]]

We fail the disabled-scriptlevel-1 reftests because of this.

Comment 1

[Manish Goregaokar [:manishearth]]

P2, Tor Browser needs this.

Comment 2

[Manish Goregaokar [:manishearth]]

Realized that Tor Browser uses ESR so this doesn't have to block stylo 57. Back to P3.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1388881 - Use namespace id instead of atom in synthesize_presentational_hints_for_legacy_attributes.

Using namespace id fixes this issue because in Gecko, the pref of MathML
(as well as SVG) works in the way that we choose a different namespace
id (the disabled id) for the elements. Those ids are mapped to the same
namespace atom as normal ids, which means if we use the atom, we would
treat the elements like normal mathml elements.

Review commit: https://reviewboard.mozilla.org/r/166962/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166962/

Comment 4

[Manish Goregaokar [:manishearth]]

Comment on attachment 8895687 [details]
Bug 1388881 - Use namespace id instead of atom in synthesize_presentational_hints_for_legacy_attributes.

https://reviewboard.mozilla.org/r/166962/#review172100

Comment 5

[Mozilla Autoland]

hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 2 changes to 2 files
remote: (b8b3e6915d65 modifies servo/components/style/gecko/wrapper.rs from Servo; not enforcing peer review)
remote: (1 changesets contain changes to protected servo/ directory: b8b3e6915d65)
remote: ************************************************************************
remote: you do not have permissions to modify files under servo/
remote: 
remote: the servo/ directory is kept in sync with the canonical upstream
remote: repository at https://github.com/servo/servo
remote: 
remote: changes to servo/ are only allowed by the syncing tool and by sheriffs
remote: performing cross-repository "merges"
remote: 
remote: to make changes to servo/, submit a Pull Request against the servo/servo
remote: GitHub project
remote: ************************************************************************
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.e_prevent_vendored hook failed
abort: push failed on remote

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Servo PR: servo/servo#18033

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8895687 [details]
Bug 1388881 - Use namespace id instead of atom in synthesize_presentational_hints_for_legacy_attributes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166962/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdcd393313a8
Use namespace id instead of atom in synthesize_presentational_hints_for_legacy_attributes. r=manishearth

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fdcd393313a8