1388938 - Make sure channel annotation and flashblock are disabled in all tests harnesses

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P3)

Description

[François Marier [:francois]]

These prefs should be added to all of the test harnesses that disable Safe Browsing:

  privacy.trackingprotection.annotate_channels = false
  plugins.flashBlock.enabled = false

See https://reviewboard.mozilla.org/r/166296/diff/1#index_header for a good list of such harnesses.

Comment 1

[François Marier [:francois]]

Attachment: Bug 1388938 - Disable channel annotation and flashblock in tests harnesses.

Since these tests harnesses are already disabling Safe Browsing and tracking
protection, they should also disable the other two features that cause
lists to be downloaded from the Mozilla shavar server.

Review commit: https://reviewboard.mozilla.org/r/171886/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171886/

Comment 2

[Henry Chang [:hchang]]

Comment on attachment 8900502 [details]
Bug 1388938 - Disable channel annotation and flashblock in tests harnesses.

https://reviewboard.mozilla.org/r/171886/#review177270

Looks good! Thanks!

Just curious, 'plugins.flashBlock.enabled', 'privacy.trackingprotection.annotate_channels' 
and 'privacy.trackingprotection.pbmode.enabled' are |true| by default now so does that mean we are 
currently failing on some tests? ^^"

Comment 3

[François Marier [:francois]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b99165a25a6901fd270d03dc8226003762696a4

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cbad3a6fc6e
Disable channel annotation and flashblock in tests harnesses.r=hchang

Comment 5

[François Marier [:francois]]

(In reply to Henry Chang [:hchang] from comment #2)
> Just curious, 'plugins.flashBlock.enabled',
> 'privacy.trackingprotection.annotate_channels' 
> and 'privacy.trackingprotection.pbmode.enabled' are |true| by default now so
> does that mean we are 
> currently failing on some tests? ^^"

I don't believe so. The tests I changed disable network services to reduce intermittent failures and races I think.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3cbad3a6fc6e

Comment 7

[Ionuț Goldan [:igoldan]]

Looks like this caused an improvement on one of our Talos tests:

== Change summary for alert #9006 (as of August 24 2017 18:32 UTC) ==

Improvements:

 25%  sessionrestore_many_windows windows10-64 opt e10s     4,107.08 -> 3,079.17

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=9006