1389078 - Sandbox Broker relies on <sys/cdefs.h> breaking non-glibc

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Bug 1389078 - Remove (unneeded) usage of internal libc header.

Review commit: https://reviewboard.mozilla.org/r/167148/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167148/

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Comment on attachment 8895857 [details]
Bug 1389078 - Remove (unneeded) usage of internal libc header.

https://reviewboard.mozilla.org/r/167148/#review172504

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a08211592563
Remove (unneeded) usage of internal libc header. r=jld

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a08211592563

Comment 5

[Jory A. Pratt [:anarchy]]

Comment on attachment 8895857 [details]
Bug 1389078 - Remove (unneeded) usage of internal libc header.

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:

Comment 6

[Gian-Carlo Pascutto [:gcp]]

[Feature/Bug causing the regression]: Bug 1308400
[User impact if declined]: Increased burden on maintainers of downstream distros
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Landed a few days ago
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No, zero risk. 
[Why is the change risky/not risky?]: Build-time change only. It either works or there's no build.
[String changes made/needed]: N/A

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8895857 [details]
Bug 1389078 - Remove (unneeded) usage of internal libc header.

A build time change and should be low risk. Beta56+.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e27747354e0