Closed Bug 1389078 Opened 2 years ago Closed 2 years ago

Sandbox Broker relies on <sys/cdefs.h> breaking non-glibc

Categories

(Core :: Security: Process Sandboxing, defect, P1)

x86_64
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: gcp, Assigned: gcp)

References

Details

(Whiteboard: sb+)

Attachments

(1 file)

No description provided.
Blocks: 1308400
Assignee: nobody → gpascutto
Priority: -- → P1
Whiteboard: sb+
Comment on attachment 8895857 [details]
Bug 1389078 - Remove (unneeded) usage of internal libc header.

https://reviewboard.mozilla.org/r/167148/#review172504
Attachment #8895857 - Flags: review?(jld) → review+
Pushed by gpascutto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a08211592563
Remove (unneeded) usage of internal libc header. r=jld
https://hg.mozilla.org/mozilla-central/rev/a08211592563
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment on attachment 8895857 [details]
Bug 1389078 - Remove (unneeded) usage of internal libc header.

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:
Attachment #8895857 - Flags: approval-mozilla-beta?
[Feature/Bug causing the regression]: Bug 1308400
[User impact if declined]: Increased burden on maintainers of downstream distros
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Landed a few days ago
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No, zero risk. 
[Why is the change risky/not risky?]: Build-time change only. It either works or there's no build.
[String changes made/needed]: N/A
Comment on attachment 8895857 [details]
Bug 1389078 - Remove (unneeded) usage of internal libc header.

A build time change and should be low risk. Beta56+.
Attachment #8895857 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.