1389133 - gtk_widget_get_style_context: assertion 'GTK_IS_WIDGET (widget)' failed

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

There's a minor regression from Bug 1365556.

MOZ_GTK_COMBOBOX_SEPARATOR may not be defined for some themes so GetWidget(MOZ_GTK_COMBOBOX_SEPARATOR) can return null. We count with that:

https://dxr.mozilla.org/mozilla-central/source/widget/gtk/gtk3drawing.cpp#1122

but the patch from Bug 1365556 always expect widget != null and calls  gtk_widget_get_style_context(widget) on it which causes the 

gtk_widget_get_style_context: assertion 'GTK_IS_WIDGET (widget)' failed

message.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1389133 - don't invalidate style content for missing widgets,

Review commit: https://reviewboard.mozilla.org/r/167168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167168/

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 8895886 [details]
Bug 1389133 - don't invalidate style content for missing widgets,

https://reviewboard.mozilla.org/r/167168/#review172578

Thank you :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcbf487465de
don't invalidate style content for missing widgets, r=karlt

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dcbf487465de

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8895886 [details]
Bug 1389133 - don't invalidate style content for missing widgets,

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1365556
[User impact if declined]: Error messages on console, crash on some systems (Bug 1388810)
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: not risky, it's a straightforward null pointer check 
[String changes made/needed]: none

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8895886 [details]
Bug 1389133 - don't invalidate style content for missing widgets,

Fix a regression. Beta56+.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f23356034754