gtk_widget_get_style_context: assertion 'GTK_IS_WIDGET (widget)' failed

RESOLVED FIXED in Firefox 56

Status

()

Core
Widget: Gtk
P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

({regression})

Trunk
mozilla57
x86_64
Linux
regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 fixed, firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
There's a minor regression from Bug 1365556.

MOZ_GTK_COMBOBOX_SEPARATOR may not be defined for some themes so GetWidget(MOZ_GTK_COMBOBOX_SEPARATOR) can return null. We count with that:

https://dxr.mozilla.org/mozilla-central/source/widget/gtk/gtk3drawing.cpp#1122

but the patch from Bug 1365556 always expect widget != null and calls  gtk_widget_get_style_context(widget) on it which causes the 

gtk_widget_get_style_context: assertion 'GTK_IS_WIDGET (widget)' failed

message.
Comment hidden (mozreview-request)

Updated

9 months ago
Duplicate of this bug: 1388810

Updated

9 months ago
status-firefox55: --- → unaffected
status-firefox56: --- → affected
status-firefox-esr52: --- → unaffected

Comment 3

9 months ago
mozreview-review
Comment on attachment 8895886 [details]
Bug 1389133 - don't invalidate style content for missing widgets,

https://reviewboard.mozilla.org/r/167168/#review172578

Thank you :)
Attachment #8895886 - Flags: review?(karlt) → review+

Updated

9 months ago
Blocks: 1365556
No longer depends on: 1365556
(Assignee)

Updated

9 months ago
Keywords: checkin-needed
Assignee: nobody → stransky

Comment 4

9 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dcbf487465de
don't invalidate style content for missing widgets, r=karlt
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dcbf487465de
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Please nominate this for Beta approval when you get a chance.
Flags: needinfo?(stransky)
(Assignee)

Comment 7

9 months ago
Comment on attachment 8895886 [details]
Bug 1389133 - don't invalidate style content for missing widgets,

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1365556
[User impact if declined]: Error messages on console, crash on some systems (Bug 1388810)
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: not risky, it's a straightforward null pointer check 
[String changes made/needed]: none
Flags: needinfo?(stransky)
Attachment #8895886 - Flags: approval-mozilla-beta?

Updated

9 months ago
Duplicate of this bug: 1391812

Comment 9

9 months ago
Comment on attachment 8895886 [details]
Bug 1389133 - don't invalidate style content for missing widgets,

Fix a regression. Beta56+.
Attachment #8895886 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 10

9 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/f23356034754
status-firefox56: affected → fixed
You need to log in before you can comment on or make changes to this bug.