138918 - understanding privacy button has no effect

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[Brant Gurganus]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.9+)
Gecko/20020419
BuildID:    2002041903

The understanding privacy button in preferences under privacy & security, in
cookies, does not work.

Reproducible: Always
Steps to Reproduce:
1. Open preferences.
2. Navigate to Privacy & Security > Cookies.
3. Click the Understanding Privacy button.

Actual Results:  Nothing happens.

Expected Results:  The understanding privacy window opens.

In the JavaScript console, the following appears when the button is pressed:
Error: viewTutorial is not defined

Comment 1

[Boris Zbarsky [:bzbarsky]]

To wallet.

Comment 2

[Stephen P. Morse]

Cookies is a better component for this.

Problem occurred as part of checkin for bug 75338 (overhaul of main menus).  The 
viewTutorial routine was removed from cookieOverlay.js at that time, but not put 
anywhere else.  Attaching patch to remedy it by putting the original 
ViewTutorial routine into pref-cookies.xul.

Comment 3

[Stephen P. Morse]

Attachment: put back the viewTutorial function

Comment 4

[Samir Gehani]

Comment on attachment 80330 [details] [diff] [review]
put back the viewTutorial function

r=sgehani

Comment 5

[jag (Peter Annema)]

Comment on attachment 80330 [details] [diff] [review]
put back the viewTutorial function

sr=jag

Comment 6

[Stephen P. Morse]

Patch checked into trunk.  Awaiting approval for branch checkin.

Comment 7

[Stephen P. Morse]

tever, please test so we can get approval for branch checkin

Comment 8

[Jaime Rodriguez, Jr.]

Adding adt2/nsbeta1+ as this is funtionality that should work (but, the
population who try to access this button might be small).

Adding dave barrowman for Marketing input.

Comment 9

[Stephen P. Morse]

This is not a new feature -- it's functionality that worked up until a few weeks 
ago when the menu items were restructured and this was accidently broken.  So 
this is a regression.

Comment 10

[Tom Everingham]

verified on trunk, 04/23/02 builds winNT4, Linux rh6, mac osX

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 80330 [details] [diff] [review]
put back the viewTutorial function

a=[e-mail] for branch checkin

Comment 12

[Jaime Rodriguez, Jr.]

[adt2 RTM]/adt1.0.0-, as very few people will ever see this, and the information
is available in the help.

Comment 13

[Brant Gurganus]

This is working now in build 2002050308/WinXP.

Comment 14

[André Dahlqvist]

Noticed this with a CVS checkout from the 1.0.0 branch. The fix looks extremely
safe, and it would make us look like morons if Understanding Privacy did not
work in 1.0.

Nominating for mozilla1.0.

Comment 15

[Stephen P. Morse]

removing minus to get back on ADT radar.

Comment 16

[Peter Trudelle]

fixed

Comment 17

[Tom Everingham]

verified branch - 05/20/02 builds, mac osX, win NT4, linux rh6

Comment 18

[scottputterman]

adding adt1.0.0+.  Please get drivers approval since it's been more than 3 days
and then check into the 1.0 branch.

Comment 19

[Tom Everingham]

arrrgh!  disregard my last comment, i was getting confused with some of the
builds I have installed.

Comment 20

[Tom Everingham]

back to resolved fixed

Comment 21

[Stephen P. Morse]

Drivers re-approval just received from Valeski.  Fix checked in on branch

Comment 22

[Tom Everingham]

verified branch - 05/28/02 builds, mac osX, win NT4, linux rh6

Comment 23

[Alvin DUAN]

---
This bug still happens to Netscape 7.0 PR1 on Solaris and Windows;
--- Reopened and comments added by [e-mail]

Comment 24

[Stephen P. Morse]

But there is no longer an "Understanding Privacy" button.  If you are seeing 
such a button, then we have bigger problems.  See bug 149357.  That is the bug 
report that you should be reopening if you still see this button.

Comment 25

[Tom Everingham]

Alvin, are you looking at a current branch build?

verified