1389227 - Crash in InvalidArrayIndex_CRASH | mozilla::gfx::VRSystemManagerOpenVR::StopVibrateHaptic

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-9ec52f90-58fa-4fc5-8181-e99970170810.
=============================================================

Seen while going through nightly crash data - only a few installs all on Windows 10: http://bit.ly/2vrpGeq

Comment 1

[Daosheng Mu[:daoshengmu]]

It looks like we access the controllers that are removed and still be called.

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1389227 - Avoid accessing invalid array index in vr controllers when stopping vibrate;

Review commit: https://reviewboard.mozilla.org/r/167492/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167492/

Comment 3

[:kip (Kearwood Gilbert)]

Comment on attachment 8896202 [details]
Bug 1389227 - Avoid accessing invalid array index in vr controllers when stopping vibrate;

https://reviewboard.mozilla.org/r/167492/#review174700

lgtm, thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cb6a8e0de5f
Avoid accessing invalid array index in vr controllers when stopping vibrate; r=kip

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5cb6a8e0de5f

Comment 6

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8896202 [details]
Bug 1389227 - Avoid accessing invalid array index in vr controllers when stopping vibrate;

Approval Request Comment
[Feature/Bug causing the regression]: Accessing invalid array index of vr controllers
[User impact if declined]: Crashes will continue to happen.
[Is this code covered by automated tests?]: Nope. I have tested manually.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: Nope. It is a very simple fix, and it will not have any danger.
[List of other uplifts needed for the feature/fix]: nope.
[Is the change risky?]: nope.
[Why is the change risky/not risky?]: Just adding a condition for avoiding accessing the invalid index. 
[String changes made/needed]: nope.

Comment 7

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8896202 [details]
Bug 1389227 - Avoid accessing invalid array index in vr controllers when stopping vibrate;

Crash fix for webVR, please uplift for beta 5.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b6f681ea1788