Crash in InvalidArrayIndex_CRASH | mozilla::gfx::VRSystemManagerOpenVR::StopVibrateHaptic

RESOLVED FIXED in Firefox 56

Status

()

Core
WebVR
--
critical
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: marcia, Assigned: daoshengmu)

Tracking

({crash})

Trunk
mozilla57
Unspecified
Windows 10
crash
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 wontfix, firefox56 fixed, firefox57 fixed)

Details

(crash signature)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
This bug was filed from the Socorro interface and is 
report bp-9ec52f90-58fa-4fc5-8181-e99970170810.
=============================================================

Seen while going through nightly crash data - only a few installs all on Windows 10: http://bit.ly/2vrpGeq
(Assignee)

Updated

11 months ago
Assignee: nobody → dmu
(Assignee)

Comment 1

11 months ago
It looks like we access the controllers that are removed and still be called.
Comment hidden (mozreview-request)

Comment 3

10 months ago
mozreview-review
Comment on attachment 8896202 [details]
Bug 1389227 - Avoid accessing invalid array index in vr controllers when stopping vibrate;

https://reviewboard.mozilla.org/r/167492/#review174700

lgtm, thanks!
Attachment #8896202 - Flags: review?(kgilbert) → review+

Comment 4

10 months ago
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5cb6a8e0de5f
Avoid accessing invalid array index in vr controllers when stopping vibrate; r=kip

Comment 5

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5cb6a8e0de5f
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(Assignee)

Comment 6

10 months ago
Comment on attachment 8896202 [details]
Bug 1389227 - Avoid accessing invalid array index in vr controllers when stopping vibrate;

Approval Request Comment
[Feature/Bug causing the regression]: Accessing invalid array index of vr controllers
[User impact if declined]: Crashes will continue to happen.
[Is this code covered by automated tests?]: Nope. I have tested manually.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: Nope. It is a very simple fix, and it will not have any danger.
[List of other uplifts needed for the feature/fix]: nope.
[Is the change risky?]: nope.
[Why is the change risky/not risky?]: Just adding a condition for avoiding accessing the invalid index. 
[String changes made/needed]: nope.
Attachment #8896202 - Flags: approval-mozilla-beta?
Comment on attachment 8896202 [details]
Bug 1389227 - Avoid accessing invalid array index in vr controllers when stopping vibrate;

Crash fix for webVR, please uplift for beta 5.
Attachment #8896202 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 8

10 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/b6f681ea1788
status-firefox56: --- → fixed
status-firefox55: --- → wontfix
status-firefox-esr52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.