1389256 - Fix incomplete handling of RepairedRtpStreamId from webrtc.org backport of RtpStreamId

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Description

[Michael Froman [:mjf]]

When I backported RtpStreamId support from webrtc.org, I missed a few places were RepairedRtpStreamId was used.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1389256 - fix incomplete handling of RepairedRtpStreamId after webrtc.org backport of RtpStreamId.

During my backport of RtpStreamId from webrtc.org, I missed a few
places where RepairedRtpStreamId was used or was not completely
implemented.  Also, the webrtc.org code used repairedStreamId,
which is not really correct per the spec (draft-ietf-avtext-rid)
so I fixed all occurances to use the correct repairedRtpStreamId
to avoid confusion later.

The RTP header extensions default IDs for RtpStreamId and
RepairedRtpStreamId were also adjusted to not collide with
PlayoutDelay's default ID.

Review commit: https://reviewboard.mozilla.org/r/167284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167284/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8896013 [details]
Bug 1389256 - fix incomplete handling of RepairedRtpStreamId after webrtc.org backport of RtpStreamId.

https://reviewboard.mozilla.org/r/167284/#review172520

Comment 3

[Michael Froman [:mjf]]

Comment on attachment 8896013 [details]
Bug 1389256 - fix incomplete handling of RepairedRtpStreamId after webrtc.org backport of RtpStreamId.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/167284/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aec707871c36
fix incomplete handling of RepairedRtpStreamId after webrtc.org backport of RtpStreamId. r=bwc

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/aec707871c36