1389342 - Weird alignment of device icons in Synced History

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Grisha Kruglov]

Attachment: history-sync.png

See screenshot. Seems like row elements are evenly spaced out.

Comment 1

[Jing-wei Wu [:jwu]]

Looks like this issue is caused by Photon with new icons.

Comment 2

[Jing-wei Wu [:jwu]]

This regression is caused by bug 1383736 that the value of 'favicon_bg' in dimens.xml is changed from '32dp' to '112dp'. 

But since the size of favicon in TwoLinePageRow has been changed to refer 'favicon_small_size', device icons in history page should use its value as width and height to keep all icons have identical size in history page.

Comment 3

[Jing-wei Wu [:jwu]]

Attachment: Bug 1389342 - Use value of 'favicon_small_size' as width/height for device icon in history page.

The size of favicon in TwoLinePageRow has been changed to refer 'favicon_small_size',
device icons in history page should use it as width and height to keep all icons have identical size.

Review commit: https://reviewboard.mozilla.org/r/169042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169042/

Comment 4

[Wesly Huang (EPM)]

[Triage@0816] Max, would you help set it tracking-fennec:+ with P1 as Jingwei is on it already? Thanks.

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8897741 [details]
Bug 1389342 - Use value of 'favicon_small_size' as width/height for device icon in history page.

https://reviewboard.mozilla.org/r/169042/#review174536

Comment 7

[Julian Chu [:walkingice]]

Comment on attachment 8897741 [details]
Bug 1389342 - Use value of 'favicon_small_size' as width/height for device icon in history page.

https://reviewboard.mozilla.org/r/169042/#review175176

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c289e7c3995d
Use value of 'favicon_small_size' as width/height for device icon in history page. r=nechen,walkingice

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c289e7c3995d

Comment 10

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 57 (2017-08-24).
Devices:
Xiaomi Mi Pad 2 (Android 5.1)
Oneplus Two (Android 6.0.1)
Prestigio Grace X5 (Android 4.4.2)