1389440 - stylo: Replace pseudo style with the one which has animation style

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

To make content property animatable we need to use the pseudo style with animations to generate element corresponding to animating content.

See bug 1382136 comment 23.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=49920d68292d4b7270acb0e7748497d3006384c2

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1389440 - Replace pseudo style with the one having animations before generating elements corresponding to content propery.

This needs for content property animations.

Review commit: https://reviewboard.mozilla.org/r/167510/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167510/

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8896214 [details]
Bug 1389440 - Replace pseudo style with the one having animations before generating elements corresponding to content propery.

https://reviewboard.mozilla.org/r/167510/#review172696

::: layout/base/nsCSSFrameConstructor.cpp:1951
(Diff revision 1)
> +      // above. We need to grab style with animations from the pseudo element
> +      // and replace old one.
> +      mPresShell->StyleSet()->AsServo()->StyleNewSubtree(container);
> +      pseudoStyleContext =
> +        styleSet->AsServo()->ResolveServoStyle(container,
> +                                               ServoTraversalFlags::Empty);

This is somewhat icky, in the sense that we're calling StyleNewSubtree when we just have a single element, then StyleNewChildren after... But, I guess.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Yeah, it's a bit spooky but I have no other idea...
Anyway, thanks for the quick review! I will land this after I confirmed the try is green.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15af7a521401
Replace pseudo style with the one having animations before generating elements corresponding to content propery. r=emilio

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/15af7a521401