Allow changing urlbar and search input background and text color

VERIFIED FIXED in Firefox 57

Status

defect
P5
normal
VERIFIED FIXED
2 years ago
Last year

People

(Reporter: ntim, Assigned: ntim)

Tracking

(Depends on 1 bug, Blocks 1 bug, {dev-doc-complete})

unspecified
mozilla57
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified)

Details

(Whiteboard: [vivaldifox-blockers])

Attachments

(1 attachment)

toolbar_field_background
toolbar_field_color
Blocks: 1386004
Priority: -- → P5
Comment on attachment 8900174 [details]
Bug 1389465 - Allow changing urlbar and search input background and text color.

https://reviewboard.mozilla.org/r/171558/#review177042

r=me but please wait for r+ from Dao too.
Attachment #8900174 - Flags: review?(jaws) → review+
Comment on attachment 8900174 [details]
Bug 1389465 - Allow changing urlbar and search input background and text color.

https://reviewboard.mozilla.org/r/171558/#review177150

::: browser/themes/shared/compacttheme.inc.css:34
(Diff revision 2)
>    --chrome-selection-color: #fff;
>    --chrome-selection-background-color: #5675B9;
>  
>    /* Url and search bars */
>    --url-and-searchbar-background-color: rgb(71, 71, 73);
> +  --url-and-searchbar-color: var(--chrome-color);

This will make the search bar dark in the Dark theme even when moved to the overflow panel. The previous rule prevented this...
Comment on attachment 8900174 [details]
Bug 1389465 - Allow changing urlbar and search input background and text color.

https://reviewboard.mozilla.org/r/171558/#review177434
Attachment #8900174 - Flags: review?(dao+bmo) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8f18edbc3e37
Allow changing urlbar and search input background and text color. r=dao,jaws
https://hg.mozilla.org/mozilla-central/rev/8f18edbc3e37
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Keywords: dev-doc-needed
Depends on: 1394008
I've updated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/theme with these new properties, but let me know if we need anything else.
Flags: needinfo?(ntim.bugs)
See bug 1387582
Flags: needinfo?(ntim.bugs)
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(ntim.bugs)
Whiteboard: [vivaldifox-blockers]
(In reply to Victor Carciu from comment #11)
> Is manual testing required on this bug? If Yes, please provide some STR and
> the proper webextension(if required), if No set the “qe-verify-“ flag.

You can try looking at VivaldiFox: https://addons.mozilla.org/en-US/firefox/addon/vivaldifox/

The add-on settings page has controls for "toolbar fields"
(In reply to Tim Nguyen :ntim from comment #12)
> (In reply to Victor Carciu from comment #11)
> > Is manual testing required on this bug? If Yes, please provide some STR and
> > the proper webextension(if required), if No set the “qe-verify-“ flag.
> 
> You can try looking at VivaldiFox:
> https://addons.mozilla.org/en-US/firefox/addon/vivaldifox/
> 
> The add-on settings page has controls for "toolbar fields"

Thanks Tim.

I verified with your add-on and I was able to change urlbar and search input background and text color using Build identifier: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0. 
Marking issue as verified...
Status: RESOLVED → VERIFIED
Blocks: themingapi-more-ui
No longer blocks: themingapi
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.