1389465 - Allow changing urlbar and search input background and text color

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P5)

Description

[Tim Nguyen :ntim]

toolbar_field_background
toolbar_field_color

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1389465 - Allow changing urlbar and search input background and text color.

Review commit: https://reviewboard.mozilla.org/r/171558/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171558/

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8900174 [details]
Bug 1389465 - Allow changing urlbar and search input background and text color.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171558/diff/1-2/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8900174 [details]
Bug 1389465 - Allow changing urlbar and search input background and text color.

https://reviewboard.mozilla.org/r/171558/#review177042

r=me but please wait for r+ from Dao too.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8900174 [details]
Bug 1389465 - Allow changing urlbar and search input background and text color.

https://reviewboard.mozilla.org/r/171558/#review177150

::: browser/themes/shared/compacttheme.inc.css:34
(Diff revision 2)
>    --chrome-selection-color: #fff;
>    --chrome-selection-background-color: #5675B9;
>  
>    /* Url and search bars */
>    --url-and-searchbar-background-color: rgb(71, 71, 73);
> +  --url-and-searchbar-color: var(--chrome-color);

This will make the search bar dark in the Dark theme even when moved to the overflow panel. The previous rule prevented this...

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8900174 [details]
Bug 1389465 - Allow changing urlbar and search input background and text color.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171558/diff/2-3/

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8900174 [details]
Bug 1389465 - Allow changing urlbar and search input background and text color.

https://reviewboard.mozilla.org/r/171558/#review177434

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f18edbc3e37
Allow changing urlbar and search input background and text color. r=dao,jaws

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8f18edbc3e37

Comment 9

[Will Bamberg [:wbamberg]]

I've updated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/theme with these new properties, but let me know if we need anything else.

Comment 10

[Tim Nguyen :ntim]

See bug 1387582

Comment 11

[Victor Carciu]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.

Comment 12

[Tim Nguyen :ntim]

(In reply to Victor Carciu from comment #11)
> Is manual testing required on this bug? If Yes, please provide some STR and
> the proper webextension(if required), if No set the “qe-verify-“ flag.

You can try looking at VivaldiFox: https://addons.mozilla.org/en-US/firefox/addon/vivaldifox/

The add-on settings page has controls for "toolbar fields"

Comment 13

[Victor Carciu]

(In reply to Tim Nguyen :ntim from comment #12)
> (In reply to Victor Carciu from comment #11)
> > Is manual testing required on this bug? If Yes, please provide some STR and
> > the proper webextension(if required), if No set the “qe-verify-“ flag.
> 
> You can try looking at VivaldiFox:
> https://addons.mozilla.org/en-US/firefox/addon/vivaldifox/
> 
> The add-on settings page has controls for "toolbar fields"

Thanks Tim.

I verified with your add-on and I was able to change urlbar and search input background and text color using Build identifier: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0. 
Marking issue as verified...