1389490 - Favicon-less tabs look odd in Nightly

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: favicon-less tab

Steps to reproduce:

1. Go to data:text/html,<title>hello</title>

Expected results: 
The page does not have favicon, so a default one is shown (used to be a globe)

Actual results:
There is no icon (not a big deal though), and the tabs looks weird next to other ones (see attachment)

Comment 1

[:Gijs (he/him)]

I think this has always been the case? Maybe it's the removal of centering of small titles that looks odd? ( bug 1389008 )

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Right, in DevEdition there is no favicon as well, but the title was centered which looks less weird I guess.

Comment 3

[Dão Gottwald [:dao]]

I don't think it's inherently weird, likely just takes some getting used to. We've shipped the combination of no centering and no default favicon for quite some time on Windows and Linux.

Comment 4

[Sören Hentzschel]

Attachment: screenshot

I have to agree… The tab with the "New Tab" title looks *very weird*. :( Please consider reverting the change or adding a default favicon, but the current state looks like an error for me. I attached a screenshot with a few more tabs to see better how weird this looks between the other tabs with favicons.

I already asked in bug 1389008 for reason of this change (the bug description says "more consistent with other platforms" but this can be solved in the one or the other direction). Now, with a few tabs more opened, I realized how bad this looks.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Aug-12-2017 11-30-40.mp4

Note that it also looks weird for tabs that usually do have favicon, but it is not shown after a browser restart until the tab is active (which makes the title "jump"). 

I'm fine with the title left-aligned, maybe we just need to have a padding similar to the favicon width for tabs where it isn't shown.