Closed Bug 1389495 Opened 4 years ago Closed 4 years ago

OOP <select> drop-down doesn't work in sidebars

Categories

(WebExtensions :: Frontend, defect, P1)

55 Branch
defect

Tracking

(firefox57 verified, firefox58 verified)

VERIFIED FIXED
mozilla57
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: eros_uk, Assigned: mixedpuppy)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

59 bytes, text/x-review-board-request
kmag
: review+
Details
1.03 MB, application/x-zip-compressed
Details
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170805085114

Steps to reproduce:

The <select> drop down menu is showing but not working in sidebar. (FF56.0b1 64bit)

Tomislav suggested setting 'extensions.webextensions.remote' to false and after reloading the extension, the drop down menu worked fine in the sidebar.

The default 'extensions.webextensions.remote' is true and users will not be expected to change it.

related to: Bug 1190679
Depends on: webext-oop
This has to be a very recent regression, I've got an addon that I test various things with including dropdowns like this.  I didn't notice this the last time I looked (1-2 weeks ago at most).

This also affects browser and page action.  It does not seem to affect other dropdowns (e.g. datalist).
Flags: needinfo?(kmaglione+bmo)
Priority: -- → P1
Summary: <select> Drop-down Menu doesn't work in Sidebar → OOP <select> Drop-down Menu doesn't work
Flags: needinfo?(kmaglione+bmo)
Summary: OOP <select> Drop-down Menu doesn't work → OOP <select> drop-down Menu doesn't work in sidebars
Summary: OOP <select> drop-down Menu doesn't work in sidebars → OOP <select> drop-down doesn't work in sidebars
Not sure that title is accurate still.

STR:

- load an extension with a sidebar, browseraction and pageaction, all with a select dropdown
- page/browser actions work fine if used first
- use dropdown in sidebar
- try page/browser actions again

expected:

- dropdowns work everywhere

actual:

- once you use the drop down in the sidebar, dropdowns do not work in any extension panel.



Probably need to find the regression window, I'm fairly certain this wasn't an issue before.
OOP needs another attribute for the dropdown.
Assignee: nobody → mixedpuppy
Comment on attachment 8897054 [details]
Bug 1389495 support select in OOP sidebar,

https://reviewboard.mozilla.org/r/168346/#review173566
Attachment #8897054 - Flags: review?(kmaglione+bmo) → review+
Pushed by mixedpuppy@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9f3981bb36b4
support select in OOP sidebar, r=kmag
https://hg.mozilla.org/mozilla-central/rev/9f3981bb36b4
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Attached file Desktop.zip
I can reproduce this issue on Firefox 57.0a1 (20170814100258) under Wind 7 64-bit. 

This issue is verified as fixed on Firefox 57.0b10 (20171019140425) and Firefox 58.0a1 (20171020100426) under Wind 7 64-bit and Mac OS X 10.13.

Using the STR from comment 2, the <select> drop-down is working if you use the drop-down from sidebar then the drop-down from the browser action.

Please see the attached videos.
Status: RESOLVED → VERIFIED
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.