Add async version of nsISessionStartup::willOverrideHomepage

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
For bug 1054740, I need an async version of willOverrideHomepage that waits till the session file has been read. Unfortunately, touching the idl means I can't use artifact builds, and full builds are somehow broken for me locally. The result is that I'm quite handicapped right now. I'd like to get the idl change landed with a stub implementation so that I can enjoy artifact builds again.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(In reply to Dão Gottwald [::dao] from comment #0)
> Unfortunately, touching the idl means I
> can't use artifact builds, and full builds are somehow broken for me
> locally.

It is really unfortunate to leave the obsolete attribute just for satisfying one developer's local build environment. Is there a bug to improve the situation?
Flags: needinfo?(dao+bmo)
Assignee

Comment 4

2 years ago
It's not just for my own satisfaction, I'm trying to get important work done. :/ (bug 1388628)

I don't know if there are plans to support idl changes in artifact build or if that's even possible.

I'd also really like to get my build issue resolved, but the obscure failure happens about one hour into the build process, so this is quite painful to iterate on as well.
Flags: needinfo?(dao+bmo)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8896328 [details]
Bug 1389525 - Add async version of nsISessionStartup::willOverrideHomepage.

https://reviewboard.mozilla.org/r/167578/#review172804
Attachment #8896328 - Flags: review?(mdeboer) → review+

Comment 6

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/40d6dab9de6d
Add async version of nsISessionStartup::willOverrideHomepage. r=mikedeboer
https://hg.mozilla.org/mozilla-central/rev/40d6dab9de6d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.