1389577 - "Remove from Toolbar" is scary for spacers

Status: NEW

(Firefox :: Toolbars and Customization, enhancement, P5)

Description

[Richard Newman [:rnewman]]

* Right-click on the default whitespace in the toolbar.
* Nothing is selected or visually indicated.
* "Remove from Toolbar" is in the menu.

Actual:
* Even as an expert user, I'm a little scared that I'm going to remove something unintentionally. Did I actually click the space? Is this going to remove the toolbar from the UI? OH NO

Expected:
* Firefox gently guides me towards peace of mind, perhaps by offering "Remove spacer from toolbar", or visually highlighting the whitespace that will be removed.

Comment 1

[:Gijs (out for now; he/him)]

(In reply to Richard Newman [:rnewman] from comment #0)
> visually highlighting the whitespace that will be removed.

At what point would it do that? The context menu offers other options as well, in which case the highlight might not make sense.

Comment 2

[Richard Newman [:rnewman]]

(In reply to :Gijs from comment #1)

> At what point would it do that? The context menu offers other options as
> well, in which case the highlight might not make sense.

The context menu offers this:

--------------------
Pin to Overflow Menu
Remove from Toolbar
--------------------
Bookmarks Toolbar
--------------------
Customize…
--------------------

The top division is right next to the click location, so it's not impossible to imagine that being visually associated with a visual highlight. One could also use wording like "Pin this to Overflow Menu" and "Remove spacer from toolbar" to identify the options that apply to the selection.

One might even imagine adjusting the menu to match, identifying the 'target' of the menu:

--------------------
= Spacer ===========
Pin to Overflow Menu
Remove from Toolbar
--------------------
Bookmarks Toolbar
--------------------
Customize…
--------------------


But anyway, I'm just spitballing -- the key point is that I felt uncertain and uncomfortable when trying to perform an action, and normal users might well feel even more uncomfortable, so we should consider whether there are ways to minimize that uncertainty and discomfort by being more explicit in some way.