Closed Bug 1389599 Opened 2 years ago Closed 2 years ago

line-height declaration in toolkit/themes/shared/about.css doesn't work

Categories

(Toolkit :: Themes, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Iteration:
57.2 - Aug 29
Tracking Status
firefox57 --- fixed

People

(Reporter: dao, Assigned: poojaarora014, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [reserve-photon-visual][p4][good first bug][lang=css])

Attachments

(1 file, 1 obsolete file)

from bug 1367326 comment 34:
> Just checked this myself on about:buildconfig. The changes are working as
> expected except for the line-height which the stylesheet needs to set after
> font rather than before it. I'll file a new bug on this.

Here's the stylesheet:

http://searchfox.org/mozilla-central/rev/4b79f3b23aebb4080ea85e94351fd4046116a957/toolkit/themes/shared/about.css#7,9

We just need to move line-height after font: message-box.
Flags: qe-verify?
Hi, could I work on this bug?
(In reply to Pooja Arora from comment #1)
> Hi, could I work on this bug?

Sure!
Assignee: nobody → poojaarora014
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 8897313 [details] [diff] [review]
Output of hg diff attached for the bug fix. checkin-needed

I don't understand this patch. Is your copy of mozilla-central up to date?
(In reply to Dão Gottwald [::dao] from comment #4)
> Comment on attachment 8897313 [details] [diff] [review]
> Output of hg diff attached for the bug fix. checkin-needed
> 
> I don't understand this patch. Is your copy of mozilla-central up to date?

Yes it is, I executed hg clone https://hg.mozilla.org/mozilla-central/ for getting the latest code, and build on top of this.
Can you please tell me if something I need to rectify.
Flags: needinfo?(dao+bmo)
Well, I just don't understand the changes in your patch. What do they have to do with this bug?
Flags: needinfo?(dao+bmo) → needinfo?(poojaarora014)
placed line-height after font: message-box
Flags: needinfo?(poojaarora014)
Have you looked at the patch yourself? What are the changes to the body and h1 rules about?
Comment on attachment 8897406 [details] [diff] [review]
with latest code-Output of hg diff attached for the bug fix. checkin-needed

Looks good, thanks!
Attachment #8897406 - Flags: review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/27a90d6952ec
Fix broken line-height declaration. r=dao
https://hg.mozilla.org/mozilla-central/rev/27a90d6952ec
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Iteration: --- → 57.2 - Aug 29
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.