I'm on today's Win64 Nightly build (I think the first one where the flexible spaces were added around the location bar?), and noticed that the stop/reload button's animation stopped working. Only noticed it after I went into Customize mode and removed the flexible spaces. The animations returned when I restarted my browser session, but go away the moment I go into and then leave customize mode. I don't have to make any actual customization changes, just enter/leave customize mode. :Bkelly is seeing the same thing, but jaws doesn't.
Using mozregression I tracked this down to the following push: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cbd6e1d73232388da836ec48f720cc6dc7a0941c&tochange=859e1832aff0bd459d8e1c1c41ce0e541e171c9e
This is broken because http://searchfox.org/mozilla-central/rev/33295c6f4d57d16fe76476ac131cadd4cd3d05ad/browser/base/content/browser-customization.js#41 calls CombinedStopReload.uninit() on entering customize mode (not a problem so far), and then http://searchfox.org/mozilla-central/rev/33295c6f4d57d16fe76476ac131cadd4cd3d05ad/browser/base/content/browser-customization.js#71 calls CombinedStopReload.init() when exiting customize mode (here's the problem). CombinedStopReload.init() sets this.animate=false and since the pref doesn't change, startAnimationPrefMonitoring() isn't going to set it back to true.
2 years ago
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 57.1 - Aug 15
Priority: -- → P1
Comment on attachment 8896496 [details] Bug 1389621 - Don't set this.animate=false during CombinedStopReload.init since pref monitoring is not guaranteed to run after init(), such is the case when exiting customize mode. https://reviewboard.mozilla.org/r/167750/#review173646
Attachment #8896496 - Flags: review?(felipc) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/180faf6c0402 Don't set this.animate=false during CombinedStopReload.init since pref monitoring is not guaranteed to run after init(), such is the case when exiting customize mode. r=Felipe
Flags: qe-verify? → qe-verify+
QA Contact: stefan.georgiev
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Build ID 20170905100117 This bug fix is Verified with latest Nightly 57.0a1.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.