1389637 - Dragging over AS Top Sites titles does not pan top sites

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

STR:
1) Open about:home on top sites
2) Drag horizontally over a title of the top sites.

Expected: top sites pager pans
Actual: No pan; An expanded circle appears as if the top sites item was clicked.

I can reproduce on my N9.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1389637: Enable Top Site scrolling when dragging TextView.

As per SO, singleLine also needed to be removed because it automatically sets
scrollHorizontally=true.

Review commit: https://reviewboard.mozilla.org/r/168868/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168868/

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8897595 [details]
Bug 1389637: Enable Top Site scrolling when dragging TextView.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168868/diff/1-2/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8897595 [details]
Bug 1389637: Enable Top Site scrolling when dragging TextView.

https://reviewboard.mozilla.org/r/168868/#review175852

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8d0007d217d
Enable Top Site scrolling when dragging TextView. r=sebastian

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f8d0007d217d

Comment 6

[Bogdan Surd, QA [:bsurd, NI]]

Devices:
 - Nexus 5 (Android 6.0.1);
 - Samsung Galaxy Tab 3	(Android 7);

 Verified this and dragging over a tile now pans the page.