Closed
Bug 1389733
Opened 7 years ago
Closed 7 years ago
Add missing Skia compile guards
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox55 | --- | wontfix |
| firefox56 | --- | fixed |
| firefox57 | --- | fixed |
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
59 bytes,
text/x-review-board-request
|
lsalzman
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
Until all #ifdef (USE_|MOZ_ENABLE_)SKIA guards are removed let's make life easier for downstream maintainers that want to revert bug 1323303.
| Comment hidden (mozreview-request) |
status-firefox55:
--- → wontfix
status-firefox56:
--- → affected
status-firefox-esr52:
--- → unaffected
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8896557 [details]
Bug 1389733 - Add missing Skia compile guards.
https://reviewboard.mozilla.org/r/167820/#review173480
Attachment #8896557 -
Flags: review?(lsalzman) → review+
Keywords: checkin-needed
|
||
Updated•7 years ago
|
Assignee: nobody → jbeich
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f616ad97907a
Add missing Skia compile guards. r=lsalzman
Keywords: checkin-needed
Comment on attachment 8896557 [details]
Bug 1389733 - Add missing Skia compile guards.
Approval Request Comment
[Feature/Bug causing the regression]: minor regressions from bug 1365358, bug 1371689, bug 1372232
[User impact if declined]: Broken build on big-endian architectures e.g., mips*, powerpc*, sparc*. This assumes downstream reverted bug 1323303 due to bug 1144632.
[Is this code covered by automated tests?]: Yes on little-endians. NPOTB otherwise.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Can only break build or accidentally disable the code from bug 1365358 due to a typo/mismerge.
[String changes made/needed]: None
Attachment #8896557 -
Flags: approval-mozilla-beta?
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Comment 6•7 years ago
|
||
Comment on attachment 8896557 [details]
Bug 1389733 - Add missing Skia compile guards.
Add missing Skia compile guards. Beta56+.
Attachment #8896557 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 7•7 years ago
|
||
| bugherder uplift | ||
|
||
Comment 8•7 years ago
|
||
(In reply to Jan Beich from comment #4)
> [Is this code covered by automated tests?]: Yes on little-endians. NPOTB
> otherwise.
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No
Setting qe-verify- based on Jan's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•