Crash in mozilla::ServoStyleContext::GetCachedInheritingAnonBoxStyle

RESOLVED FIXED in Firefox 57

Status

()

Core
CSS Parsing and Computation
--
critical
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: marcia, Assigned: emilio)

Tracking

({crash, regression})

Trunk
mozilla57
Unspecified
Windows 7
crash, regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 unaffected, firefox57 fixed)

Details

(crash signature)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

This bug was filed from the Socorro interface and is 
report bp-42701d05-7d64-43d0-9a7b-af9f00170808.
=============================================================

Seen while looking at nightly crash stats - crashes started in 20170806100257: http://bit.ly/2vYRsBY

Code was touched in Bug 1368290. ni on :emilio for investigation
Flags: needinfo?(emilio+bugs)
(Assignee)

Comment 1

9 months ago
Hmm... So I see how can this in theory happen if we have an element without a frame that has text children and isn't display: contents...

But I'm having a hard time to find a situation where that would be true... Marcia, do you know how can I look to see if there's any URL in the reports?

(Also, my patch introduces the crash, but the behaviour we had before is wrong too...)
Flags: needinfo?(emilio+bugs) → needinfo?(mozillamarcia.knous)
(Assignee)

Comment 2

9 months ago
(Sorry, I wasn't intending to remove the ni? request from me, I can still write a patch, but I don't know how to look at the crash stats for page URLs, and they would be helpful to construct a test-case).
Flags: needinfo?(emilio+bugs)
(Reporter)

Comment 3

9 months ago
(In reply to Emilio Cobos Álvarez [:emilio] from comment #2)
> (Sorry, I wasn't intending to remove the ni? request from me, I can still
> write a patch, but I don't know how to look at the crash stats for page
> URLs, and they would be helpful to construct a test-case).

Permissions are needed to see the URLs and can be requested from the Socorro team.

From what I see, the only URL showing is http://www.rawpol.com.pl/pl/fotopopup.html?img=../photo2/9024/0006019024.jpg or some variant of that site.  The other reports I looked at did not have a URL.
Flags: needinfo?(mozillamarcia.knous)
Comment hidden (mozreview-request)
(Assignee)

Updated

9 months ago
Assignee: nobody → emilio+bugs
Flags: needinfo?(emilio+bugs)

Comment 5

9 months ago
mozreview-review
Comment on attachment 8896644 [details]
Bug 1389790: Ensure we always have an up-to-date style context even if we have no frame.

https://reviewboard.mozilla.org/r/167924/#review173116
Attachment #8896644 - Flags: review?(cam) → review+

Comment 6

9 months ago
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/69d373634f87
Ensure we always have an up-to-date style context even if we have no frame. r=heycam
https://hg.mozilla.org/mozilla-central/rev/69d373634f87
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
status-firefox55: --- → unaffected
status-firefox56: --- → unaffected
status-firefox-esr52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.