Don't add caller location to sandbox name if an explicit name is provided

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

(Blocks 2 bugs)

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [qf:p3])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
GetCurrentJSStack shows up in profiles just about every time a Sandbox is constructed. The caller stack frame is not particularly useful in most cases where we already have an explicit name, so it's probably not worth the overhead.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8896656 [details]
Bug 1389847: Don't add caller location to sandbox name if an explicit name is provided.

https://reviewboard.mozilla.org/r/167948/#review173522

Makes sense to me.
Attachment #8896656 - Flags: review?(gkrizsanits) → review+
Whiteboard: [qf] → [qf:p3]

Comment 3

2 years ago
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/890e87283c5d
Don't add caller location to sandbox name if an explicit name is provided. r=krizsa

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/890e87283c5d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.