Closed Bug 1389847 Opened 4 years ago Closed 4 years ago

Don't add caller location to sandbox name if an explicit name is provided

Categories

(Core :: XPConnect, enhancement)

Product:
Core
Component:
XPConnect
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [qf:p3])

Attachments

(1 file)

Bug 1389847: Don't add caller location to sandbox name if an explicit name is provided.
59 bytes, text/x-review-board-request
gkrizsanits
: review+
Details 
GetCurrentJSStack shows up in profiles just about every time a Sandbox is constructed. The caller stack frame is not particularly useful in most cases where we already have an explicit name, so it's probably not worth the overhead.
Comment on attachment 8896656 [details]
Bug 1389847: Don't add caller location to sandbox name if an explicit name is provided.

https://reviewboard.mozilla.org/r/167948/#review173522

Makes sense to me.
Attachment #8896656 - Flags: review?(gkrizsanits) → review+
Whiteboard: [qf] → [qf:p3]
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/890e87283c5d
Don't add caller location to sandbox name if an explicit name is provided. r=krizsa
https://hg.mozilla.org/mozilla-central/rev/890e87283c5d
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.