1389847 - Don't add caller location to sandbox name if an explicit name is provided

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement)

Description

[Kris Maglione [:kmag]]

GetCurrentJSStack shows up in profiles just about every time a Sandbox is constructed. The caller stack frame is not particularly useful in most cases where we already have an explicit name, so it's probably not worth the overhead.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1389847: Don't add caller location to sandbox name if an explicit name is provided.

Review commit: https://reviewboard.mozilla.org/r/167948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167948/

Comment 2

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8896656 [details]
Bug 1389847: Don't add caller location to sandbox name if an explicit name is provided.

https://reviewboard.mozilla.org/r/167948/#review173522

Makes sense to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/890e87283c5d
Don't add caller location to sandbox name if an explicit name is provided. r=krizsa

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/890e87283c5d