1389848 - isServiceInstantiatedByContractID should return false rather than throw when component isn't instantiated

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Kris Maglione [:kmag]]

We spend several ms at startup constructing exception objects for startupRecorder.js ahen it checks for uninstantiated services. This isn't an issue for release builds, but it does add extra overhead and GC pressure for nightly talos runs, and ordinary nightly users, that we wouldn't see on release. Which means it gives us a bad picture of what's going on for normal users.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1389848: Make isServiceInstantiated*() return false rather than throw for uninstantiated services.

Review commit: https://reviewboard.mozilla.org/r/167952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167952/

Comment 2

[(no longer active)]

Comment on attachment 8896658 [details]
Bug 1389848: Make isServiceInstantiated*() return false rather than throw for uninstantiated services.

https://reviewboard.mozilla.org/r/167952/#review173466

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e19453003208
Make isServiceInstantiated*() return false rather than throw for uninstantiated services. r=ehsan

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1952f907b15b7e5a508f8b35c3b63089d949de0d
Bug 1389848: Follow-up: Bustage fix.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e19453003208
https://hg.mozilla.org/mozilla-central/rev/1952f907b15b

Comment 6

[Florian Quèze [:florian]]

If we wanted to completely avoid the startupRecorder overhead related to listing services, we should add a native method returning the list of already instantiated services, instead of having JS code iterating through all the registered contract ids. I didn't bother doing it at the time because it was nightly-only code. But thanks for improving it :-)