test_automigration.js is going to permafail when the Gecko version number is bumped 58 on 2017-09-18

VERIFIED FIXED in Firefox 57

Status

()

--
critical
VERIFIED FIXED
a year ago
19 days ago

People

(Reporter: RyanVM, Assigned: Gijs)

Tracking

(Depends on: 1 bug)

Trunk
Firefox 57
Unspecified
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57+ verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
[Tracking Requested - why for this release]: Permafailing xpcshell tests on the next merge day

Looks like the FX_STARTUP_MIGRATION_UNDO_BOOKMARKS_ERRORCOUNT probe expires in 58. What would you like to do with it, Gijs?

https://treeherder.mozilla.org/logviewer.html#?job_id=122804154&repo=try

TEST-UNEXPECTED-FAIL | browser/components/migration/tests/unit/test_automigration.js | checkUndoRemoval - [checkUndoRemoval : 301] Should have reported 0 errors to FX_STARTUP_MIGRATION_UNDO_BOOKMARKS_ERRORCOUNT. - 10230750 == 0
Flags: needinfo?(gijskruitbosch+bugs)
(Assignee)

Comment 1

a year ago
Ryan,  more accurately shouldn't this track 58? I guess bugzilla doesn't let us do that. :-(


Peter, what's the current status of automigration? Is there any chance we'll be using it at all this year? I'm somewhat inclined to scrap the unused telemetry if not, but if we intend to try to make this usable in the near-ish future I can just extend the probes...
Flags: needinfo?(ryanvm)
Flags: needinfo?(pdolanjski)
Flags: needinfo?(gijskruitbosch+bugs)
(Reporter)

Comment 2

a year ago
Yeah, no 58 tracking flags at this point.
Flags: needinfo?(ryanvm)
(In reply to :Gijs from comment #1)
> Peter, what's the current status of automigration? Is there any chance we'll
> be using it at all this year? I'm somewhat inclined to scrap the unused
> telemetry if not, but if we intend to try to make this usable in the
> near-ish future I can just extend the probes...

We likely do want to use automigration, post 57, yes.  We likely need to eliminate the jank issues first. (which was back-burnered for Photon work)
Flags: needinfo?(pdolanjski)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8899746 - Flags: review?(rweiss)
(Assignee)

Comment 5

a year ago
Rebecca, I'm effectively asking to extend these histograms in the face of comment 3. They provide telemetry about if/how we migrate data from other browsers either on first startup of Firefox, or later, at the user's initiative. This will help shape focus on that code and how we improve/change it post-57, when we (hopefully) have cycles to make it more performant and can use it to help set users up with the data they already have on their computer in Firefox automatically.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
(Reporter)

Comment 6

a year ago
Comment on attachment 8899746 [details]
Bug 1389991 - extend browser data migration telemetry probes so they continue to work on 58 and above,

Looks good on Try too.
Attachment #8899746 - Flags: feedback+

Comment 7

a year ago
mozreview-review
Comment on attachment 8899746 [details]
Bug 1389991 - extend browser data migration telemetry probes so they continue to work on 58 and above,

https://reviewboard.mozilla.org/r/171086/#review178762

This is an extension request for existing measurements.
Attachment #8899746 - Flags: review?(rweiss) → review+

Comment 8

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3a43ef28808d
extend browser data migration telemetry probes so they continue to work on 58 and above, r=rweiss+418169
https://hg.mozilla.org/mozilla-central/rev/3a43ef28808d
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
(Reporter)

Updated

a year ago
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
tracking-firefox57: ? → +
(Reporter)

Updated

8 months ago
Depends on: 1432488
Depends on: 1488926
You need to log in before you can comment on or make changes to this bug.