Closed Bug 1389992 Opened 5 years ago Closed 5 years ago

test_TelemetrySession.js is going to permafail when the Gecko version number is bumped to 58 on 2017-09-18


(Toolkit :: Telemetry, defect, P2)




Tracking Status
firefox57 - verified


(Reporter: RyanVM, Assigned: RyanVM, Mentored)


(Whiteboard: [measurement:client][lang=js])


(1 file)

[Tracking Requested - why for this release]: Permafailing tests on the next merge day after the Gecko version bump to 58.

I ran a simulation on Try of the next Gecko version number bump ( and I hit a failure in test_TelemetrySession.js that needs investigation. Can you please take a look, Alessio?

TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetrySession.js | test_sendShutdownPing - [test_sendShutdownPing : 1397] The OS shutdown scalar must be set to true. - "undefined" == true
Flags: needinfo?(alessio.placitelli)
Priority: -- → P1
Whiteboard: [measurement:client]
Thanks for filing this, Ryan!

The failure is due to the |os_shutting_down| scalar expiring on 58 [1]. I think we should let it expire and remove the related code: this scalar has been used to validate the shutdown pingsender and it's not being used for anything else.

@Georg, any thought on that? Should we keep this or go on and remove it?

[1] -
Flags: needinfo?(alessio.placitelli) → needinfo?(gfritzsche)
Removal sounds fine to me.
I think there are two parts here:
- fixing the beta test failure in this bug
- removing the code, which can be a separate (mentored?) bug
Flags: needinfo?(gfritzsche)
It's a very monday monday: i see now that this will happen on Nightly going to 58, so yes, lets just remove things.
This bug is about removing the "os_shutting_down" scalar from the Telemetry code [1] and the related test coverage [2]. In order to make sure that everything is working after the changes, xpcshell tests can be run using the following command:

> ./mach test toolkit/components/telemetry

[1] -
[2] -
Mentor: alessio.placitelli
Whiteboard: [measurement:client] → [measurement:client][lang=js]
Priority: P1 → P2
Is it OK to remove it now from 57 or did you want to wait until after the version is bumped to 58?
Flags: needinfo?(gfritzsche)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
> Is it OK to remove it now from 57 or did you want to wait until after the
> version is bumped to 58?

As per comment 3, it's ok to remove it from 57.
Flags: needinfo?(gfritzsche)
Try looks happy.
Assignee: nobody → ryanvm
Attachment #8900296 - Flags: review?(alessio.placitelli)
Comment on attachment 8900296 [details] [diff] [review]
remove the os_shutting_down scalar and related code

Review of attachment 8900296 [details] [diff] [review]:

Thanks for the help Ryan, this looks good.
Attachment #8900296 - Flags: review?(alessio.placitelli) → review+
Pushed by
Remove the os_shutting_down scalar and related code. r=dexter
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.