1390006 - browser_BrowserUITelemetry_defaults.js is going to permafail on DevEdition when Gecko 57 merges to Beta on 2017-09-20

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafailing DevEdition test on the next merge day.

Looks like this test is failing because DevEdition has an extra button on the toolbar that the test isn't expecting to be there.
https://public-artifacts.taskcluster.net/Zym-tmX2Q_e03PFcEC_RVg/0/public/test_info//mozilla-test-fail-screenshot_aQrgTf.png

https://treeherder.mozilla.org/logviewer.html#?job_id=122811906&repo=try

TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_BrowserUITelemetry_defaults.js | ["developer-button"] deepEqual [] - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser/browser_BrowserUITelemetry_defaults.js :: test :: line 25

Comment 1

[:Gijs (he/him)]

I expect this is my fault.

Comment 2

[:Gijs (he/him)]

This broke because in bug 1354117 I moved the developer button into the palette by default, and so now it counts as "added" (from the palette to the toolbar) rather than "moved" (from the panel to the toolbar).

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1390006 - fix up expectations of BrowserUITelemetry tests to match what devedition is doing,

Review commit: https://reviewboard.mozilla.org/r/168208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168208/

Comment 4

[:Gijs (he/him)]

Comment on attachment 8896929 [details]
Bug 1390006 - fix up expectations of BrowserUITelemetry tests to match what devedition is doing,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168208/diff/1-2/

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8896929 [details]
Bug 1390006 - fix up expectations of BrowserUITelemetry tests to match what devedition is doing,

https://reviewboard.mozilla.org/r/168208/#review173404

Shouldn't that assertion just test for a different array (which includes the developer-button) in devedition? But that's not what this bug is about, so r=me.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7124b5734fa
fix up expectations of BrowserUITelemetry tests to match what devedition is doing, r=johannh

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f7124b5734fa

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This is fixed, no need to track it.