1390026 - stylo: make shape-outside animatable on <basic-shape>

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Daisuke Akatsuka (:daisuke)]

For now, although shape-outside animate discretely, we should animate on <basic-shape> same as clip-path.

Comment 1

[Brian Birtles (:birtles)]

Apparently this already matches the Gecko behavior.

Comment 2

[Boris Chiou [:boris]]

TYLin and I will make shape-outside animatable on both Gecko and Servo.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1390026 - Update test_transitions_per_property.html for shape-outside.

Review commit: https://reviewboard.mozilla.org/r/180848/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180848/

Comment 4

[Brian Birtles (:birtles)]

Comment on attachment 8909258 [details]
Bug 1390026 - Update test_transitions_per_property.html for shape-outside.

https://reviewboard.mozilla.org/r/180848/#review186342

::: layout/style/test/test_transitions_per_property.html:642
(Diff revision 1)
>      round_error_ok: true },
>  ];
>  
> -var clipPathTests = [
> +// Even if the default reference-box of shape-outside is margin-box, which is
> +// different from the default reference-box of clip-path, we still can reuse
> +// this tests for both properties because we always explicitly assign a

Nit: these tests

::: layout/style/test/test_transitions_per_property.html:644
(Diff revision 1)
> +// Besides, after fixing Bug 1313619, we should add some tests for two
> +// basic shapes with an explicit reference-box and a default one.

s/Besides, after fixing Bug 1313619, we should add some tests/Bug 1313619: Add some tests/

Comment 5

[Boris Chiou [:boris]]

Thanks!

Comment 6

[Boris Chiou [:boris]]

Comment on attachment 8909258 [details]
Bug 1390026 - Update test_transitions_per_property.html for shape-outside.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180848/diff/1-2/

Comment 7

[Boris Chiou [:boris]]

Attachment: Servo PR, #18559

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1327c641da9
Update test_transitions_per_property.html for shape-outside. r=birtles

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f1327c641da9