[Onboarding] The complete sign is not shown at first time when set the performance tour as the first item

VERIFIED FIXED in Firefox 57

Status

()

defect
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: gasolin, Assigned: gasolin)

Tracking

unspecified
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified)

Details

(Whiteboard: [photon-onboarding])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Steps:

* put performance / sync / default browser as first tour by setting browser.onboarding.newtour to `performance,addons,customize,search,default,sync`
* open onboarding overlay via click fox icon
* The complete sign does not shown when any of above 3 tours is the first item

expect:

Show complete sign when first time show that tour.


The reason here is we only set those tours as auto-complete when we are handleing click event. We could handle it in gotoPage instead.
(Assignee)

Updated

2 years ago
Whiteboard: [photon-onboarding][triage]
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Assignee: nobody → gasolin
Blocks: 1366056
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Blocks: 1377298
Comment on attachment 8896873 [details]
Bug 1390042 - [Onboarding] The complete sign is not shown at first time when set the performance tour as the first item;

https://reviewboard.mozilla.org/r/168164/#review173330
Attachment #8896873 - Flags: review?(rexboy) → review+
(Assignee)

Updated

2 years ago
Flags: qe-verify+
Priority: -- → P1
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
(Assignee)

Comment 4

2 years ago
thanks
Keywords: checkin-needed
This doesn't meet the review requirements in MozReview for Autoland to push it.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html#landing-commits
Keywords: checkin-needed

Comment 6

2 years ago
Pushed by flin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f348b0c84139
[Onboarding] The complete sign is not shown at first time when set the performance tour as the first item;r=rexboy
QA Contact: jwilliams
Target Milestone: --- → Firefox 57

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f348b0c84139
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
I have verified this issue is fixed with today's nightly.
Status: RESOLVED → VERIFIED
I can confirm this issue is not occurring on Fx 57.0b7, I verified on Windows 10 x64 and mac OS X 10.12.6.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.