Bug 1390042 - [Onboarding] The complete sign is not shown at first time when set the performance tour as the first item;
59 bytes, text/x-review-board-request
Steps: * put performance / sync / default browser as first tour by setting browser.onboarding.newtour to `performance,addons,customize,search,default,sync` * open onboarding overlay via click fox icon * The complete sign does not shown when any of above 3 tours is the first item expect: Show complete sign when first time show that tour. The reason here is we only set those tours as auto-complete when we are handleing click event. We could handle it in gotoPage instead.
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Comment on attachment 8896873 [details] Bug 1390042 - [Onboarding] The complete sign is not shown at first time when set the performance tour as the first item; https://reviewboard.mozilla.org/r/168164/#review173330
Attachment #8896873 - Flags: review?(rexboy) → review+
Priority: -- → P1
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
This doesn't meet the review requirements in MozReview for Autoland to push it. http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html#landing-commits
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f348b0c84139 [Onboarding] The complete sign is not shown at first time when set the performance tour as the first item;r=rexboy
I have verified this issue is fixed with today's nightly.
Status: RESOLVED → VERIFIED
I can confirm this issue is not occurring on Fx 57.0b7, I verified on Windows 10 x64 and mac OS X 10.12.6.
You need to log in before you can comment on or make changes to this bug.