1390099 - "Menu:BrowserActionClicked" not dispatched, breaks browserAction.onClicked and pageAction.onClicked

Status: RESOLVED DUPLICATE of bug 1375857

(WebExtensions :: Android, defect)

Description

[Rob Wu [:robwu]]

When the three-dot menu on Android is opened before the startup (of extensions?) completes, then all extension menus are not triggering click events because the "Menu:BrowserActionClicked" event (for BrowserActions.jsm) is not dispatched.

(I am not sure, but the root cause might be the same as bug 1390090, where the same event is not fired for a specific extension when that extension is disabled and re-enabled).

STR:
1. browserActions are supported in Android since version 55, which is currently in Beta.
2. Have an add-on with a browserAction.onClicked listener (e.g. https://addons.mozilla.org/en-US/firefox/addon/display-_anchors/versions/?page=1#version-1.3)
3. Quit Firefox, e.g. by swiping away the app in the app drawer and waiting a few seconds to make sure that there is nothing left behind.
4. Start Firefox, and tap on the three menu dots as soon as possible.
5. When the extension menu items appear, click on it (in my example, "Display #Anchors").

6. Check whether the extension menu buttin is functional.
 - Via the extension: tap on the menu item, and expect an "Access denied" message should be shown because the default tab is is not scriptable by the extension
 - Via WebIDE, with the following code in Firefox's main process:

EventDispatcher.instance.registerListener({
  onEvent: console.log
}, 'Menu:BrowserActionClicked');
// After clicking on the menu item, expect logging message:
// "Menu:BrowserActionClicked Object ..."


Expected result:
- Step 6 should show that tapping on the menu item triggers "Menu:BrowserActionClicked"

Actual result:
- In Firefox 55 (build 20170807232150), nothing happens.


Additional information:
- If I wait a few seconds (until the startup completes) before tapping on the three menu dots in step 4, then the expected result occurs.

Comment 1

[Rob Wu [:robwu]]

Typo: I tested with version 56 (build 20170807232150), not version 55.

Comment 2

[Rob Wu [:robwu]]

Same root cause as 1375857, see:
https://bugzilla.mozilla.org/show_bug.cgi?id=1390090#c2
https://bugzilla.mozilla.org/show_bug.cgi?id=1390090#c3

The fixes have been uplifted to Firefox 56 (not published in the Play store yet). Firefox 55 is still affected.