1390147 - Remove getProperty Class hook from StatementJSHelper and AsyncStatementJSHelper

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, enhancement)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

We want to remove these ClassOps, see bug 1389510. There's more to do for storage/ but these *StatementJSHelper ones are easy to fix.

In bug 1389510 comment 3 bz mentioned we could remove these JSHelper classes completely and use IDL for the "params" and "row" properties. That's a lot more complicated though - the easiest fix is to replace the getProperty hook with a resolve hook that defines the property.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8896982 [details] [diff] [review]
Patch

Please do file follow bugs on getting rid of these scriptable helpers.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35622c347169
Remove getProperty Class hook from StatementJSHelper and AsyncStatementJSHelper. r=mrbkap

Comment 3

[Jan de Mooij [:jandem]]

(In reply to Blake Kaplan (:mrbkap) from comment #1)
> Please do file follow bugs on getting rid of these scriptable helpers.

Filed bug 1390528.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/35622c347169