Closed
Bug 1390206
Opened 7 years ago
Closed 7 years ago
AWFY - ensure that test profiles exclude experiments
Categories
(Testing Graveyard :: AWFY, enhancement)
Testing Graveyard
AWFY
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
(Whiteboard: [PI:August])
Attachments
(2 files)
bkelly asks about whether awfy's profiles exclude experiments such as enabling stylo, etc. Suggests that the experiments are tied to telemetry settings.
wlach suggests that mozprofile would automatically set the appropriate preferences and should be used if it is not already.
I'll look into this asap.
Updated•7 years ago
|
Whiteboard: [PI:August]
Assignee | ||
Comment 1•7 years ago
|
||
https://github.com/mozilla/arewefastyet/blob/master/slave/configs.py
https://github.com/mozilla/arewefastyet/blob/master/slave/executors.py
show that the prefs are constructed as a string in configs.py that is written to profile/prefs.js in executors.py.
So, we do not use mozprofile and probably don't disable the same set of preferences we do elsewhere in automation.
Assignee | ||
Comment 2•7 years ago
|
||
The first commit changes from using a string of user_pref values in profile_ to keeping the preferences in a dictionary that is passed to FirefoxProfile to create the profile.
The second commit adds the preference prefs["layout.css.servo.enabled"] = False to prevent servo from running.
We will have to install mozprofile before merging this. I intend to just do a global install via pip.
Attachment #8897153 -
Flags: review?(bbouvier)
Attachment #8897153 -
Flags: review?(armenzg)
Attachment #8897153 -
Flags: feedback?(jmaher)
Attachment #8897153 -
Flags: feedback?(bkelly)
Assignee | ||
Comment 3•7 years ago
|
||
This attachment lists the preferences set by default by mozprofile. Note they are stored in the user.js file. The prefs.js file in the profile is initialized to empty by FirefoxProfile.
Additional preferences set via the preferences argument to the constructor will appear below the initial section.
Assignee | ||
Updated•7 years ago
|
Attachment #8897153 -
Flags: feedback?(sphilp)
Comment 4•7 years ago
|
||
Comment on attachment 8897153 [details] [diff] [review]
https://github.com/mozilla/arewefastyet/pull/159
Honestly, I don't know enough about our experiments system or test infrastructure to provide feedback here. I'm just happy to see it getting looked at. Thanks!
Attachment #8897153 -
Flags: feedback?(bkelly)
Assignee | ||
Comment 5•7 years ago
|
||
One question is: Do we disable stylo or enable it by default. Currently, the patch turns it off.
Another is: Do we want to support both configurations and run both types of job?
Comment 6•7 years ago
|
||
Until we enable stylo by default I would prefer to have it disabled on AWFY. Or two separate jobs. Just my opinion, though.
Comment 7•7 years ago
|
||
Comment on attachment 8897153 [details] [diff] [review]
https://github.com/mozilla/arewefastyet/pull/159
Review of attachment 8897153 [details] [diff] [review]:
-----------------------------------------------------------------
a simple change- hard to look at code that isn't mozbase related anymore- make sure that you install all other mozprofile related packages as well.
Attachment #8897153 -
Attachment is patch: true
Attachment #8897153 -
Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8897153 -
Flags: feedback?(jmaher) → feedback+
Comment 8•7 years ago
|
||
I alluded to this in my github comment, but so it's visible here too, this is generally fine for now. I think long term we're going to at least want a simple file to map to for explicitly setting prefs like this, and perhaps one day using a service (shield may even work?) to control our automation configuration state. With a service, we could timebox experimental pref toggling (say for 24 hours) for a desired state to check results, possibly reducing the need for ballooning the number of configurations we run under (as in we'd only ever run 1 configuration, but the state of that configuration could be more dynamic).
Updated•7 years ago
|
Attachment #8897153 -
Flags: feedback?(sphilp) → feedback+
Updated•7 years ago
|
Attachment #8897153 -
Flags: review?(armenzg) → review+
Comment 9•7 years ago
|
||
Comment on attachment 8897153 [details] [diff] [review]
https://github.com/mozilla/arewefastyet/pull/159
Had one comment that I've put on Github, otherwise looks good to me, thanks!
Attachment #8897153 -
Flags: review?(bbouvier) → review+
Assignee | ||
Comment 10•7 years ago
|
||
https://github.com/mozilla/arewefastyet/commit/d07fae13804009918a0eeb4f757d7e455afa299d
https://github.com/mozilla/arewefastyet/commit/71cb9664696776ab45daf3ff6610ac87685f56a2
I followed Ben's advice. The idea of using Shield is intriguing but something to look into later rather than now. Thanks everyone!
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
Component: General → AWFY
Updated•5 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•