1390269 - Convert TOUCH_ENABLED_DEVICE to opt-out

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Jim Mathies [:jimm]]

Asa would like info about touch screen device support out on the release channel. This probe is currently opt-in and as such doesn't provide this data.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Data privacy wise I don't see this as an issue, we're just querying device info here, no different from say, cpu speed or screen dims.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8897109 [details] [diff] [review]
patch

Review of attachment 8897109 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me technically.

This still needs data review from a peer listed here:
https://wiki.mozilla.org/Firefox/Data_Collection

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8897109 [details] [diff] [review]
patch

Requesting data review from rweiss

Comment 4

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8897109 [details] [diff] [review]
patch

Review of attachment 8897109 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/Histograms.json
@@ +8163,5 @@
> +    "expires_in_version": "never",
> +    "kind": "boolean",
> +    "releaseChannelCollection": "opt-out",
> +    "bug_numbers": [795307, 1390269],
> +    "alert_emails": ["[e-mail]"],

I missed this before: you can now remove TOUCH_ENABLED_DEVICE from histogram-whitelists.json.

Comment 5

[[e-mail]]

:jimm can you please provide answers to the questions in this doc:

https://docs.google.com/document/d/1SSn5w8DfCSkHWJS8DNTd7ya82diWRxaDUFM5aL4UDDo/edit#heading=h.tdmbb3rtr1gg

Comment 6

[Jim Mathies [:jimm]]

(In reply to Rebecca Weiss from comment #5)
> :jimm can you please provide answers to the questions in this doc:
> 
> https://docs.google.com/document/d/
> 1SSn5w8DfCSkHWJS8DNTd7ya82diWRxaDUFM5aL4UDDo/edit#heading=h.tdmbb3rtr1gg

https://docs.google.com/document/d/1K4zTgM127KTA-Ty14KnKSS19KsGSXL3t5UNohmuo7Qk/edit#

Sure!

Comment 7

[[e-mail]]

Comment on attachment 8897109 [details] [diff] [review]
patch

Review of attachment 8897109 [details] [diff] [review]:
-----------------------------------------------------------------

Review is tentatively approved because this appears to be low risk, but please provide a person responsible WRT question (3) below.

1) Is there documentation that describes the schema for the ultimate data set available publicly, complete and accurate? (see here, here, and here for examples)
Yes, the request is for a boolean Telemetry probe, which means that the standard Telemetry documentation applies here.

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism)  
Yes, standard opt-out for Telemetry applies.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?
The request is for permanent data collection, so a responsible individual needs to be named.

4) Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? 
This appears to be a Type 1 data collection (determines whether the device is touch enabled, not whether they are using Touch).

5) Is the data collection default-on or default-off? 
Default-on. 

6) Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)? 
No new identifiers.

7) Is the data collection covered by the existing Firefox privacy notice? If unsure: escalate to legal.
Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?
Current request is for permanent data collection, so no.

Comment 8

[Jim Mathies [:jimm]]

Attachment: patch

thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53a7f7b59fbd
Convert TOUCH_ENABLED_DEVICE to an opt-out probe. r=gfritzsche, data=rweiss

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/53a7f7b59fbd