Update options_ui to match photon

VERIFIED FIXED in Firefox 57

Status

()

defect
P3
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: andy+bugzilla, Assigned: mstriemer)

Tracking

(Blocks 1 bug, {regression})

unspecified
mozilla58
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 wontfix, firefox57 verified, firefox58 verified)

Details

Attachments

(3 attachments)

Posted image Capture.PNG
It looks like options_ui doesn't inherit the new browser_style colors and fonts from Photon. Attached is the tab center redux options page. 

For example, it looks like the background is not being set to white by the extension:

https://github.com/eoger/tabcenter-redux/tree/master/src
The white background appears to be related to the extensions.webextensions.remote pref. Flipping that to true makes the background white, flipping it false makes it appear correctly.
Same here, looks like an OOP bug.
Blocks: webext-oop
Keywords: regression
Confirmed, it is an OOP bug.

The browser element created for the options_ui pages is missing the "transparent" attribute (which should be set to "true"), here:

- http://searchfox.org/mozilla-central/rev/d08b24e613cac8c9c5a4131452459241010701e0/toolkit/mozapps/extensions/content/extensions.js#3766-3772
Comment on attachment 8910388 [details]
Bug 1390276 - Make the options_ui background transparent

https://reviewboard.mozilla.org/r/181830/#review187678
Attachment #8910388 - Flags: review?(rhelmer) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/50e9d398db41
Make the options_ui background transparent r=rhelmer
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/50e9d398db41
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Please request Beta approval on this when you get a chance.
Flags: needinfo?(mstriemer)
Comment on attachment 8910388 [details]
Bug 1390276 - Make the options_ui background transparent

Approval Request Comment
[Feature/Bug causing the regression]: OOP extensions
[User impact if declined]: OOP extension users will see a white background in the options UI
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: I have manually verified in Nightly
[Needs manual test from QE? If yes, steps to reproduce]:
  1. Install an extension with inline options_ui (see extension in comment 0).
  2. Open about:addons.
  3. Go to the extension's detail page.
  4. Background of the options UI should match the rest of the page.
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: It's a one line change to make the <browser> element transparent
[String changes made/needed]: none
Flags: needinfo?(mstriemer)
Attachment #8910388 - Flags: approval-mozilla-beta?
Comment on attachment 8910388 [details]
Bug 1390276 - Make the options_ui background transparent

Fix a visual glitch, taking it.
Should be in 57b4, gtb later today
Attachment #8910388 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
Posted image photon match.PNG
This bug is verified on Firefox 57.0b4 (20170928180207) and Firefox 58.0a1 (20170928220658) under Windows 10 64-bit and Mac OS X 10.12.3.

Please see the attached screenshot.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.