Update options_ui to match photon

VERIFIED FIXED in Firefox 57

Status

()

P3
normal
VERIFIED FIXED
a year ago
11 months ago

People

(Reporter: andy+bugzilla, Assigned: mstriemer)

Tracking

(Blocks: 1 bug, {regression})

unspecified
mozilla58
regression
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 wontfix, firefox57 verified, firefox58 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

a year ago
Created attachment 8897112 [details]
Capture.PNG

It looks like options_ui doesn't inherit the new browser_style colors and fonts from Photon. Attached is the tab center redux options page. 

For example, it looks like the background is not being set to white by the extension:

https://github.com/eoger/tabcenter-redux/tree/master/src
(Assignee)

Comment 1

11 months ago
The white background appears to be related to the extensions.webextensions.remote pref. Flipping that to true makes the background white, flipping it false makes it appear correctly.

Comment 2

11 months ago
Same here, looks like an OOP bug.
Blocks: 1190679
Keywords: regression

Comment 3

11 months ago
Confirmed, it is an OOP bug.

The browser element created for the options_ui pages is missing the "transparent" attribute (which should be set to "true"), here:

- http://searchfox.org/mozilla-central/rev/d08b24e613cac8c9c5a4131452459241010701e0/toolkit/mozapps/extensions/content/extensions.js#3766-3772
Comment hidden (mozreview-request)

Comment 5

11 months ago
mozreview-review
Comment on attachment 8910388 [details]
Bug 1390276 - Make the options_ui background transparent

https://reviewboard.mozilla.org/r/181830/#review187678
Attachment #8910388 - Flags: review?(rhelmer) → review+
(Assignee)

Updated

11 months ago
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 6

11 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/50e9d398db41
Make the options_ui background transparent r=rhelmer
Keywords: checkin-needed

Comment 7

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/50e9d398db41
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Please request Beta approval on this when you get a chance.
status-firefox55: --- → unaffected
status-firefox56: --- → wontfix
status-firefox57: --- → affected
status-firefox-esr52: --- → unaffected
Flags: needinfo?(mstriemer)
(Assignee)

Comment 9

11 months ago
Comment on attachment 8910388 [details]
Bug 1390276 - Make the options_ui background transparent

Approval Request Comment
[Feature/Bug causing the regression]: OOP extensions
[User impact if declined]: OOP extension users will see a white background in the options UI
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: I have manually verified in Nightly
[Needs manual test from QE? If yes, steps to reproduce]:
  1. Install an extension with inline options_ui (see extension in comment 0).
  2. Open about:addons.
  3. Go to the extension's detail page.
  4. Background of the options UI should match the rest of the page.
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: It's a one line change to make the <browser> element transparent
[String changes made/needed]: none
Flags: needinfo?(mstriemer)
Attachment #8910388 - Flags: approval-mozilla-beta?
Comment on attachment 8910388 [details]
Bug 1390276 - Make the options_ui background transparent

Fix a visual glitch, taking it.
Should be in 57b4, gtb later today
Attachment #8910388 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 11

11 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/3ab379041f96
status-firefox57: affected → fixed
Flags: qe-verify+

Comment 12

11 months ago
Created attachment 8913627 [details]
photon match.PNG

This bug is verified on Firefox 57.0b4 (20170928180207) and Firefox 58.0a1 (20170928220658) under Windows 10 64-bit and Mac OS X 10.12.3.

Please see the attached screenshot.

Updated

11 months ago
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
status-firefox58: fixed → verified
You need to log in before you can comment on or make changes to this bug.