1390276 - Update options_ui to match photon

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Andy McKay]

Attachment: Capture.PNG

It looks like options_ui doesn't inherit the new browser_style colors and fonts from Photon. Attached is the tab center redux options page. 

For example, it looks like the background is not being set to white by the extension:

https://github.com/eoger/tabcenter-redux/tree/master/src

Comment 1

[Mark Striemer [:mstriemer]]

The white background appears to be related to the extensions.webextensions.remote pref. Flipping that to true makes the background white, flipping it false makes it appear correctly.

Comment 2

[Kestrel]

Same here, looks like an OOP bug.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Confirmed, it is an OOP bug.

The browser element created for the options_ui pages is missing the "transparent" attribute (which should be set to "true"), here:

- http://searchfox.org/mozilla-central/rev/d08b24e613cac8c9c5a4131452459241010701e0/toolkit/mozapps/extensions/content/extensions.js#3766-3772

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1390276 - Make the options_ui background transparent

Review commit: https://reviewboard.mozilla.org/r/181830/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181830/

Comment 5

[Robert Helmer [:rhelmer]]

Comment on attachment 8910388 [details]
Bug 1390276 - Make the options_ui background transparent

https://reviewboard.mozilla.org/r/181830/#review187678

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50e9d398db41
Make the options_ui background transparent r=rhelmer

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/50e9d398db41

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 9

[Mark Striemer [:mstriemer]]

Comment on attachment 8910388 [details]
Bug 1390276 - Make the options_ui background transparent

Approval Request Comment
[Feature/Bug causing the regression]: OOP extensions
[User impact if declined]: OOP extension users will see a white background in the options UI
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: I have manually verified in Nightly
[Needs manual test from QE? If yes, steps to reproduce]:
  1. Install an extension with inline options_ui (see extension in comment 0).
  2. Open about:addons.
  3. Go to the extension's detail page.
  4. Background of the options UI should match the rest of the page.
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: It's a one line change to make the <browser> element transparent
[String changes made/needed]: none

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8910388 [details]
Bug 1390276 - Make the options_ui background transparent

Fix a visual glitch, taking it.
Should be in 57b4, gtb later today

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3ab379041f96

Comment 12

[marius.santa]

Attachment: photon match.PNG

This bug is verified on Firefox 57.0b4 (20170928180207) and Firefox 58.0a1 (20170928220658) under Windows 10 64-bit and Mac OS X 10.12.3.

Please see the attached screenshot.